ReferenceFilter: consider only the reference name

That's all we need right now, and it will make the thing easier to
test.

Author: mhagger

git-sizer.go

@@ -300,12 +300,12 @@ func mainImplementation(args []string) error {
 	if showRefs {
 		oldRefFilter := refFilter
 		fmt.Fprintf(os.Stderr, "References (included references marked with '+'):\n")
-		refFilter = func(ref git.Reference) bool {
-			b := oldRefFilter(ref)
+		refFilter = func(refname string) bool {
+			b := oldRefFilter(refname)
 			if b {
-				fmt.Fprintf(os.Stderr, "+ %s\n", ref.Refname)
+				fmt.Fprintf(os.Stderr, "+ %s\n", refname)
 			} else {
-				fmt.Fprintf(os.Stderr, "  %s\n", ref.Refname)
+				fmt.Fprintf(os.Stderr, "  %s\n", refname)
 			}
 			return b
 		}

git/ref_filter.go

@@ -5,9 +5,9 @@ import (
 	"strings"
 )
 
-type ReferenceFilter func(Reference) bool
+type ReferenceFilter func(refname string) bool
 
-func AllReferencesFilter(_ Reference) bool {
+func AllReferencesFilter(_ string) bool {
 	return true
 }
 
@@ -43,10 +43,10 @@ func (ief *IncludeExcludeFilter) Exclude(f ReferenceFilter) {
 	ief.filters = append(ief.filters, polarizedFilter{Exclude, f})
 }
 
-func (ief *IncludeExcludeFilter) Filter(r Reference) bool {
+func (ief *IncludeExcludeFilter) Filter(refname string) bool {
 	for i := len(ief.filters); i > 0; i-- {
 		f := ief.filters[i-1]
-		if !f.filter(r) {
+		if !f.filter(refname) {
 			continue
 		}
 		return f.polarity == Include
@@ -66,14 +66,14 @@ func (ief *IncludeExcludeFilter) Filter(r Reference) bool {
 //   "refs/foobar".
 func PrefixFilter(prefix string) ReferenceFilter {
 	if strings.HasSuffix(prefix, "/") {
-		return func(r Reference) bool {
-			return strings.HasPrefix(r.Refname, prefix)
+		return func(refname string) bool {
+			return strings.HasPrefix(refname, prefix)
 		}
 	}
 
-	return func(r Reference) bool {
-		return strings.HasPrefix(r.Refname, prefix) &&
-			(len(r.Refname) == len(prefix) || r.Refname[len(prefix)] == '/')
+	return func(refname string) bool {
+		return strings.HasPrefix(refname, prefix) &&
+			(len(refname) == len(prefix) || refname[len(prefix)] == '/')
 	}
 }
 
@@ -87,7 +87,7 @@ func RegexpFilter(pattern string) (ReferenceFilter, error) {
 		return nil, err
 	}
 
-	return func(r Reference) bool {
-		return re.MatchString(r.Refname)
+	return func(refname string) bool {
+		return re.MatchString(refname)
 	}, nil
 }

sizes/graph.go

@@ -62,7 +62,7 @@ func ScanRepositoryUsingGraph(
 			if !ok {
 				break
 			}
-			if !filter(ref) {
+			if !filter(ref.Refname) {
 				continue
 			}
 			refs = append(refs, ref)