HistorySize.TableString(): generate "no problems" message here

mhagger · mhagger · commit e1129722989e · 2018-08-20T22:24:04.000+02:00
diff --git a/sizes/output.go b/sizes/output.go
@@ -107,9 +107,6 @@ func (s *section) Emit(t *table, buf io.Writer, indent int) {
 	}
 
 	if linesBuf.Len() == 0 {
-		if indent == -1 {
-			fmt.Fprintln(buf, "No problems above the current threshold were found")
-		}
 		return
 	}
 
@@ -330,7 +327,7 @@ func (s HistorySize) TableString(threshold Threshold, nameStyle NameStyle) strin
 	t.contents.Emit(&t, buf, -1)
 
 	if buf.Len() == 0 {
-		return ""
+		return "No problems above the current threshold were found\n"
 	}
 
 	return t.generateHeader() + buf.String() + t.footnotes.String()

Original file line number	Diff line number	Diff line change
`@@ -107,9 +107,6 @@ func (s section) Emit(t table, buf io.Writer, indent int) {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`if linesBuf.Len() == 0 {`
`110`		`- if indent == -1 {`
`111`		`- fmt.Fprintln(buf, "No problems above the current threshold were found")`
`112`		`- }`
`113`	`110`	`return`
`114`	`111`	`}`
`115`	`112`
`@@ -330,7 +327,7 @@ func (s HistorySize) TableString(threshold Threshold, nameStyle NameStyle) strin`
`330`	`327`	`t.contents.Emit(&t, buf, -1)`
`331`	`328`
`332`	`329`	`if buf.Len() == 0 {`
`333`		`- return ""`
	`330`	`+ return "No problems above the current threshold were found\n"`
`334`	`331`	`}`
`335`	`332`
`336`	`333`	`return t.generateHeader() + buf.String() + t.footnotes.String()`