rubocop

Author: mlinksva

Gemfile

@@ -11,7 +11,7 @@ group :jekyll_plugins do
 end
 
 group :development, :test do
-  gem 'html-proofer', "~> 4.0"
+  gem 'html-proofer', '~> 4.0'
   gem 'parallel'
   gem 'rake'
   gem 'rubocop'

Rakefile

@@ -10,11 +10,12 @@ task :test do
     check_external_hash: false,
     hydra: { max_concurrency: 10 },
     url_ignore: [%r{https://developer.github.com}, %r{https://docs.github.com}, %r{https://help.github.com}],
-    ignore_status_codes: [429])
-  token = ENV['GITHUB_TOKEN']
-  if defined? token
+    ignore_status_codes: [429]
+  )
+  token = ENV.fetch('GITHUB_TOKEN', nil)
+  unless token.nil?
     proofer.before_request do |request|
-      request.options[:headers]['Authorization'] = "Bearer #{token}" if request.base_url == "https://github.com"
+      request.options[:headers]['Authorization'] = "Bearer #{token}" if request.base_url == 'https://github.com'
     end
   end
   proofer.run

script/alphabetize

@@ -10,7 +10,7 @@ require 'yaml'
 files = Dir["#{File.expand_path('../_data/', File.dirname(__FILE__))}/*.yml"]
 
 files.each do |file|
-  contents = File.open(file).read
+  contents = File.read(file)
   comment = contents.lines.first
 
   data = YAML.safe_load(contents)
@@ -25,5 +25,5 @@ files.each do |file|
   # Add extra line break between groups, indent arrays, and strip header
   formatted_output = comment + output.to_yaml.gsub(/^(.+?):$/, "\n\\1:").gsub(/^- /, '  - ').gsub(/\A---\n/m, '')
 
-  File.open(file, 'w') { |f| f.write(formatted_output) }
+  File.write(file, formatted_output)
 end

script/ensure-orgs

@@ -48,7 +48,7 @@ files.each do |file|
     data[group] = data[group] - not_orgs
   end
 
-  comment = File.open(file).read.lines.first
+  comment = File.read(file).lines.first
   output = comment
   output << "\n"
   output << data.to_yaml.sub(/\A---\n/, '').gsub(/^-/, '  -').gsub(/\n([^ ])/, "\n\n\\1")

script/fetch-cfa

@@ -31,7 +31,7 @@ module CFA
       org_file['Code for All'] = code_for_all_orgs
       org_file['Civic Hackers'] = civic_hackers - brigades - code_for_all_orgs + to_be_removed
 
-      comment = File.open(org_file_path).read.lines.first
+      comment = File.read(org_file_path).lines.first
       output = comment
       output << "\n"
       output << org_file.to_yaml.sub(/\A---\n/, '').gsub(/^-/, '  -').gsub(/\n([^ ])/, "\n\n\\1")

script/fetch-us

@@ -47,7 +47,7 @@ org_file['U.S. Federal'] = org_file['U.S. Federal'].uniq.sort_by(&:upcase)
 puts "\n\nMissing from registry:"
 puts((us_gov - orgs.map(&:downcase)).to_yaml)
 
-comment = File.open(org_file_path).read.lines.first
+comment = File.read(org_file_path).lines.first
 output = comment
 output << "\n"
 output << org_file.to_yaml.sub(/\A---\n/, '').gsub(/^-/, '  -').gsub(/\n([^ ])/, "\n\n\\1")