test(variables): add failing tests for noop mode support

These tests document the bug where the variables plugin does not
respect the nop flag. When nop=true, the plugin should:
- Return NopCommand objects instead of making API calls
- NOT make actual GitHub API calls

Currently all noop tests fail, demonstrating the bug exists.

Signed-off-by: Kyle Harding <kyle@balena.io>

Author: klutchell

test/unit/lib/plugins/variables.test.js

@@ -1,5 +1,6 @@
 const { when } = require('jest-when')
 const Variables = require('../../../../lib/plugins/variables')
+const NopCommand = require('../../../../lib/nopcommand')
 
 describe('Variables', () => {
   let github
@@ -10,13 +11,13 @@ describe('Variables', () => {
     return variables
   }
 
-  function configure () {
-    const log = { debug: console.debug, error: console.error }
+  function configure (nop = false) {
+    const log = { debug: jest.fn(), error: console.error }
     const errors = []
-    return new Variables(undefined, github, { owner: org, repo }, [{ name: 'test', value: 'test' }], log, errors)
+    return new Variables(nop, github, { owner: org, repo }, [{ name: 'test', value: 'test' }], log, errors)
   }
 
-  beforeAll(() => {
+  beforeEach(() => {
     github = {
       request: jest.fn().mockReturnValue(Promise.resolve(true))
     }
@@ -76,4 +77,134 @@ describe('Variables', () => {
       )
     })
   })
+
+  describe('noop mode', () => {
+    describe('add', () => {
+      it('should return NopCommand and not make API call when nop is true', async () => {
+        const plugin = configure(true)
+        const variable = { name: 'NEW_VAR', value: 'new-value' }
+
+        const result = await plugin.add(variable)
+
+        expect(result).toBeInstanceOf(NopCommand)
+        expect(result.plugin).toBe('Variables')
+        expect(github.request).not.toHaveBeenCalledWith(
+          'POST /repos/:org/:repo/actions/variables',
+          expect.anything()
+        )
+      })
+
+      it('should make API call when nop is false', async () => {
+        const plugin = configure(false)
+        const variable = { name: 'NEW_VAR', value: 'new-value' }
+
+        await plugin.add(variable)
+
+        expect(github.request).toHaveBeenCalledWith(
+          'POST /repos/:org/:repo/actions/variables',
+          expect.objectContaining({
+            org,
+            repo,
+            name: 'NEW_VAR',
+            value: 'new-value'
+          })
+        )
+      })
+    })
+
+    describe('remove', () => {
+      it('should return NopCommand and not make API call when nop is true', async () => {
+        const plugin = configure(true)
+        const existing = { name: 'EXISTING_VAR', value: 'existing-value' }
+
+        const result = await plugin.remove(existing)
+
+        expect(result).toBeInstanceOf(NopCommand)
+        expect(result.plugin).toBe('Variables')
+        expect(github.request).not.toHaveBeenCalledWith(
+          'DELETE /repos/:org/:repo/actions/variables/:variable_name',
+          expect.anything()
+        )
+      })
+
+      it('should make API call when nop is false', async () => {
+        const plugin = configure(false)
+        const existing = { name: 'EXISTING_VAR', value: 'existing-value' }
+
+        await plugin.remove(existing)
+
+        expect(github.request).toHaveBeenCalledWith(
+          'DELETE /repos/:org/:repo/actions/variables/:variable_name',
+          expect.objectContaining({
+            org,
+            repo,
+            variable_name: 'EXISTING_VAR'
+          })
+        )
+      })
+    })
+
+    describe('update', () => {
+      it('should return NopCommand and not make API calls when nop is true', async () => {
+        const plugin = configure(true)
+        const existing = [{ name: 'VAR1', value: 'old-value' }]
+        const updated = [{ name: 'VAR1', value: 'new-value' }]
+
+        const result = await plugin.update(existing, updated)
+
+        expect(result).toBeInstanceOf(NopCommand)
+        expect(result.plugin).toBe('Variables')
+        expect(github.request).not.toHaveBeenCalledWith(
+          'PATCH /repos/:org/:repo/actions/variables/:variable_name',
+          expect.anything()
+        )
+      })
+
+      it('should return NopCommand when adding new variable in update with nop true', async () => {
+        const plugin = configure(true)
+        const existing = []
+        const updated = [{ name: 'NEW_VAR', value: 'new-value' }]
+
+        const result = await plugin.update(existing, updated)
+
+        expect(result).toBeInstanceOf(NopCommand)
+        expect(github.request).not.toHaveBeenCalledWith(
+          'POST /repos/:org/:repo/actions/variables',
+          expect.anything()
+        )
+      })
+
+      it('should return NopCommand when deleting variable in update with nop true', async () => {
+        const plugin = configure(true)
+        const existing = [{ name: 'OLD_VAR', value: 'old-value' }]
+        const updated = []
+
+        const result = await plugin.update(existing, updated)
+
+        expect(result).toBeInstanceOf(NopCommand)
+        expect(github.request).not.toHaveBeenCalledWith(
+          'DELETE /repos/:org/:repo/actions/variables/:variable_name',
+          expect.anything()
+        )
+      })
+
+      it('should make API calls when nop is false', async () => {
+        const plugin = configure(false)
+        const existing = [{ name: 'VAR1', value: 'old-value' }]
+        const updated = [{ name: 'VAR1', value: 'new-value' }]
+
+        await plugin.update(existing, updated)
+
+        expect(github.request).toHaveBeenCalledWith(
+          'PATCH /repos/:org/:repo/actions/variables/:variable_name',
+          expect.objectContaining({
+            org,
+            repo,
+            variable_name: 'VAR1',
+            value: 'new-value'
+          })
+        )
+      })
+    })
+  })
 })