Skip to content
This repository was archived by the owner on Apr 1, 2025. It is now read-only.

Commit e60cf72

Browse files
author
Patrick Thomson
committed
Add language detailing policy re. PR approvals/change requests.
We've seen some members of the public come in and leave distracting reviews on our pull requests. This patch adds a clause to our contributing documentation that outlines why we don't want people to continue doing this.
1 parent 23df12a commit e60cf72

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

CONTRIBUTING.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ Here are a few things you can do that will increase the likelihood of your pull
2828
- Keep your change as focused as possible. If there are multiple changes you would like to make that are not dependent upon each other, consider submitting them as separate pull requests.
2929
- Write a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
3030

31+
Unless you are a member of the Semantic team or a code owner, we ask that you refrain from leaving approvals or change requests on in-progress pull requests, as spurious reviews make it difficult to discern which patches are truly ready for integration.
32+
3133
Please be aware that contributions to Semantic may multiple cycles of code review—we are grateful for all community involvement, but because Semantic powers real systems, we must maintain a high standard of code quality. For reasons of compatibility with production uses of Semantic within GitHub, we may also reject or require modifications to changes that would affect these systems. We may also reject patches that don't fit with our vision of the project; should this be the case, we will be clear about our rationale.
3234

3335
## Resources

0 commit comments

Comments
 (0)