Skip to content

Commit 1d641ef

Browse files
authored
Merge pull request #189 from github0null/dev
v3.10.4 revision
2 parents 11e75eb + 0647e5d commit 1d641ef

6 files changed

Lines changed: 28 additions & 8 deletions

File tree

CHANGELOG.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,16 @@ All notable version changes will be recorded in this file.
66

77
***
88

9+
### [v3.10.4] revision
10+
11+
**Fix**:
12+
- `Task type: 'eide.msys'`: The `env` property does not work.
13+
14+
**Change**:
15+
- `Task type: 'eide.msys'`: Use `label` property for task title, not `name`
16+
17+
***
18+
919
### [v3.10.3] revision
1020

1121
**New**:

package.json

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"homepage": "https://em-ide.com",
3636
"license": "MIT",
3737
"description": "A mcu development environment for 8051/AVR/STM8/Cortex-M/RISC-V",
38-
"version": "3.10.3",
38+
"version": "3.10.4",
3939
"preview": false,
4040
"engines": {
4141
"vscode": "^1.63.0"
@@ -1569,14 +1569,18 @@
15691569
{
15701570
"type": "eide.msys",
15711571
"required": [
1572-
"name",
1572+
"label",
15731573
"command"
15741574
],
15751575
"properties": {
1576-
"name": {
1576+
"label": {
15771577
"type": "string",
15781578
"description": "Task Name. A human-readable name for this task"
15791579
},
1580+
"name": {
1581+
"type": "string",
1582+
"description": "**Deprecated !!!** Task Name. A human-readable name for this task"
1583+
},
15801584
"command": {
15811585
"type": "string",
15821586
"description": "Command. A shell command will be executed."

res/data/.clang-format

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ SortIncludes: false
3535

3636
AlignConsecutiveMacros: AcrossEmptyLines
3737

38-
#AlignConsecutiveAssignments: AcrossEmptyLines
38+
AlignConsecutiveAssignments: Consecutive

res/html/builder_options/js/app.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/EIDEProjectExplorer.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4176,6 +4176,10 @@ export class ProjectExplorer implements CustomConfigurationProvider {
41764176
throw new Error(`Not found any reference for this source file !, [path]: '${srcPath}'`);
41774177
}
41784178

4179+
if (!File.IsFile(objPath)) {
4180+
throw new Error(`Object file is not existed !, [path]: '${objPath}'`);
4181+
}
4182+
41794183
// prepare command
41804184
let exeFile: File;
41814185
let cmds: string[];

src/extension.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1164,7 +1164,9 @@ function RegisterGlobalEvent() {
11641164

11651165
interface EideShellTaskDef extends vscode.TaskDefinition {
11661166

1167-
name: string;
1167+
label: string;
1168+
1169+
name?: string;
11681170

11691171
command: string;
11701172

@@ -1192,14 +1194,14 @@ class EideTaskProvider implements vscode.TaskProvider {
11921194
const definition: EideShellTaskDef = <any>task_.definition;
11931195

11941196
const task = new vscode.Task(definition, vscode.TaskScope.Workspace,
1195-
definition.name, EideTaskProvider.TASK_TYPE_MSYS, definition.problemMatchers);
1197+
definition.name || definition.label, EideTaskProvider.TASK_TYPE_MSYS, definition.problemMatchers);
11961198

11971199
const shellcommand = definition.command;
11981200
task.execution = new vscode.ShellExecution(shellcommand, {
11991201
executable: platform.osType() == 'win32' ? `${process.env['EIDE_MSYS']}/bash.exe` : '/bin/bash',
12001202
shellArgs: ['-c'],
12011203
cwd: definition?.options?.cwd || workspaceManager.getCurrentFolder()?.path,
1202-
env: utility.mergeEnv(process.env, {})
1204+
env: utility.mergeEnv(process.env, definition.env || {})
12031205
});
12041206

12051207
task.group = definition.group;

0 commit comments

Comments
 (0)