Skip to content

Commit 375c64e

Browse files
committed
use 'label', not 'name' in task
1 parent 79a0966 commit 375c64e

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

package.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1569,14 +1569,18 @@
15691569
{
15701570
"type": "eide.msys",
15711571
"required": [
1572-
"name",
1572+
"label",
15731573
"command"
15741574
],
15751575
"properties": {
1576-
"name": {
1576+
"label": {
15771577
"type": "string",
15781578
"description": "Task Name. A human-readable name for this task"
15791579
},
1580+
"name": {
1581+
"type": "string",
1582+
"description": "**Deprecated !!!** Task Name. A human-readable name for this task"
1583+
},
15801584
"command": {
15811585
"type": "string",
15821586
"description": "Command. A shell command will be executed."

src/extension.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1164,7 +1164,9 @@ function RegisterGlobalEvent() {
11641164

11651165
interface EideShellTaskDef extends vscode.TaskDefinition {
11661166

1167-
name: string;
1167+
label: string;
1168+
1169+
name?: string;
11681170

11691171
command: string;
11701172

@@ -1192,7 +1194,7 @@ class EideTaskProvider implements vscode.TaskProvider {
11921194
const definition: EideShellTaskDef = <any>task_.definition;
11931195

11941196
const task = new vscode.Task(definition, vscode.TaskScope.Workspace,
1195-
definition.name, EideTaskProvider.TASK_TYPE_MSYS, definition.problemMatchers);
1197+
definition.name || definition.label, EideTaskProvider.TASK_TYPE_MSYS, definition.problemMatchers);
11961198

11971199
const shellcommand = definition.command;
11981200
task.execution = new vscode.ShellExecution(shellcommand, {

0 commit comments

Comments
 (0)