Skip to content

Commit 98ede7a

Browse files
authored
remove unused code, rename api
1 parent 6277a9d commit 98ede7a

1 file changed

Lines changed: 5 additions & 13 deletions

File tree

src/EIDETypeDefine.ts

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -340,19 +340,11 @@ export abstract class Configuration<ConfigType = any, EventType = any> {
340340
}
341341
}
342342

343-
// set default value for error value property
344-
for (const key in (<any>this.config)) {
345-
if (!isNullOrUndefined((<any>this.config)[key])) {
346-
if (typeof _configFromFile[key] !== typeof (<any>this.config)[key]) {
347-
_configFromFile[key] = (<any>this.config)[key];
348-
}
349-
}
350-
}
351-
352343
// set config
353344
this.config = _configFromFile;
354345

355-
this.loadAfterConfigUpdated();
346+
//
347+
this.afterSetConfigData();
356348

357349
this._event.emit('dataChanged');
358350
}
@@ -361,8 +353,8 @@ export abstract class Configuration<ConfigType = any, EventType = any> {
361353
this.watcher.file.Write(this.ToJson());
362354
}
363355

364-
protected loadAfterConfigUpdated() {
365-
// do nothing
356+
protected afterSetConfigData() {
357+
// TODO
366358
}
367359

368360
protected Parse(jsonStr: string): ConfigType {
@@ -1337,7 +1329,7 @@ export class ProjectConfiguration<T extends BuilderConfigData>
13371329

13381330
//---
13391331

1340-
protected loadAfterConfigUpdated() {
1332+
protected afterSetConfigData() {
13411333

13421334
//
13431335
// load target

0 commit comments

Comments
 (0)