Skip to content

Commit b290812

Browse files
committed
misc update
1 parent 915506c commit b290812

3 files changed

Lines changed: 25 additions & 12 deletions

File tree

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,11 @@ You can build this project by your self.
122122
> [!NOTE]
123123
> There may be syntax errors when opening project source code using VSCode, this is because the project uses an older Version of TypeScript, please press `Ctrl+Shift+P` to execute `TypeScript: Select TypeScript Version...` and select version: `v3.9.x`.
124124
125+
## Contribution Guidelines
126+
127+
If you have any good ideas, you can first put forward your suggestions in the issue section. If they are feasible, we will implement them later. If you want to add features by yourself, please also share your ideas at the very beginning (otherwise, we cannot guarantee that your PR will be merged).
128+
If you are ready and have completed the debugging and testing, then you can submit a pull request request to the dev branch. Thanks.
129+
125130
## Sponsor 👍
126131

127132
[Sponsor The Author](https://em-ide.com/sponsor)

README_ZH-CN.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,14 @@
9797
> [!NOTE]
9898
> 注意:VSCode 打开工程源码可能会语法报错,这是由于这个项目使用了较老版本的 TypeScript,请按下 `Ctrl+Shift+P` 执行 `TypeScript: Select TypeScript Version...` 选择工作区中的版本 `v3.9.x`.
9999
100+
## 贡献指南
101+
102+
如果您有什么好的想法,可以先在issue中提出意见,如果可行稍后我们会进行实现。
103+
104+
如果您现在就想自己动手添加功能,那么也请在一开始先提出您的想法(否则我们不能保证您的PR被合并),避免浪费您的时间。
105+
106+
在完成了更改后,如果您确保没有其他问题,那么您可以向 dev 分支提出 pull request 请求,稍后我们会进行审核。
107+
100108
## 赞助 👍
101109

102110
[请作者喝咖啡](https://em-ide.com/sponsor)

src/extension.ts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2203,18 +2203,18 @@ class ExternalDebugConfigProvider implements vscode.DebugConfigurationProvider {
22032203
if (m && m.length > 1) {
22042204
dbgCfg['probe'] = m[1];
22052205
}
2206-
// parse '--chip-description-path <path>' (support quoted path)
2207-
// examples:
2208-
// --chip-description-path /path/to/desc.yaml
2209-
// --chip-description-path "/path/with spaces/desc.yaml"
2210-
m = /--chip-description-path\s+("[^"]+"|[^\s]+)/.exec(flasherCfg.otherOptions);
2211-
if (m && m.length > 1) {
2212-
let p = m[1];
2213-
// strip surrounding quotes if present
2214-
if (p.startsWith('"') && p.endsWith('"'))
2215-
p = p.substring(1, p.length - 1);
2216-
dbgCfg['chipDescriptionPath'] = p;
2217-
}
2206+
// parse '--chip-description-path <path>' (support quoted path)
2207+
// examples:
2208+
// --chip-description-path /path/to/desc.yaml
2209+
// --chip-description-path "/path/with spaces/desc.yaml"
2210+
m = /--chip-description-path\s+("[^"]+"|[^\s]+)/.exec(flasherCfg.otherOptions);
2211+
if (m && m.length > 1) {
2212+
let p = m[1];
2213+
// strip surrounding quotes if present
2214+
if (p.startsWith('"') && p.endsWith('"'))
2215+
p = p.substring(1, p.length - 1);
2216+
dbgCfg['chipDescriptionPath'] = p;
2217+
}
22182218
}
22192219
result.push(dbgCfg);
22202220
result.push(newAttachDebugCfg(dbgCfg));

0 commit comments

Comments
 (0)