Editor crashes on exit with extension loaded, after AHashMap sync (ce03221)

[SneaK1ng]

Godot version

fb1821384

godot-cpp version

ce03221

System information

win11 9700x+5070ti

Issue description

I ran into a crash after updating to ce03221.

Our extension registers a lot of classes, and now the editor consistently crashes at the very end of shutdown. Right before the crash I get: ERROR: Parameter "singleton" is null

followed by orphan StringName warnings (e.g. "Node"), then an access violation.

Going back to 193e164 fixes the crash.

Steps to reproduce

godot --headless --editor --quit

Minimal reproduction project

None

[dsnopek]

Thanks!

However, I'm unable to reproduce this in a test project. Can you share your project or an MRP that demonstrates the issue?

[Ivorforce]

Possibly related to #1900 and/or #2004

[SneaK1ng]

Update: I got this wrong earlier...
the crash has nothing to do with any specific godot-cpp commit. The real trigger is the first editor scan.

can repro it with any test project:

Build test/
(master, MSVC, scons platform=windows target=template_debug)
Delete test/project/.godot

godot --headless --editor --quit --path test/project (godot master fb1821384, Win)
First run crashes right at the end of shutdown, just after EditorSettings: Save OK!. Second run exits fine since the cache exists by then. Old godot-cpp versions crash the same way — when I tested different commits before, what actually changed between runs was whether a reimport happened, not the commit. And it doesn't crash without the extension.

The last thing in the log before the crash is the editor doc cache thread, so maybe a shutdown race with extension teardown.
Might be a godot problem rather than godot-cpp.

[Ivorforce]

Good to know! That makes it really likely it's the same as #1900, which I've tracked down to the same issue.

[2shady4u]

I am facing the same issue.

================================================================
handle_crash: Program crashed with signal 11
Engine version: Godot Engine v4.7.1.stable.custom_build (a13da4feb8d8aefc283c3763d33a2f170a18d541)
Dumping the backtrace. Please include this when reporting the bug on: https://github.com/godotengine/godot/issues
Load address: 5620baf25000

[1] 7da8ae80d330 (libc.so.6+45330) - /lib/x86_64-linux-gnu/libc.so.6(+0x45330) [0x7da8ae80d330]
[2] 5620bde3aff9 (main+2f15ff9) - HashMap<String, DocData::ClassDoc, HashMapHasherDefault, HashMapComparatorDefault<String, void>, DefaultTypedAllocator<HashMapElement<String, DocData::ClassDoc> > >::operator[](String const&) at /godot/core/templates/hash_map.h:561
[3] 5620bde29fea (main+2f04fea) - DocTools::generate(BitField<DocTools::GenerateFlags>) at /godot/editor/doc/doc_tools.cpp:452 (discriminator 1)
[4] 5620bde6c471 (main+2f47471) - EditorHelp::_gen_extensions_docs() at /godot/editor/doc/editor_help.cpp:3087
[5] 5620bc0adf20 (main+1188f20) - void call_with_variant_args_static<>(void (*)(), Variant const**, Callable::CallError&, IndexSequence<>) at /godot/core/variant/binder_common.h:534
[6] 5620bc0adbda (main+1188bda) - void call_with_variant_args_static<>(void (*)(), Variant const**, int, Callable::CallError&) at /godot/core/variant/binder_common.h:600
[7] 5620bc0ad488 (main+1188488) - CallableCustomStaticMethodPointer<void>::call(Variant const**, int, Variant&, Callable::CallError&) const at /godot/core/object/callable_mp.h:249
[8] 5620c14fef28 (main+65d9f28) - Callable::callp(Variant const**, int, Variant&, Callable::CallError&) const at /godot/core/variant/callable.cpp:58
[9] 5620c190ed96 (main+69e9d96) - CallQueue::_call_function(Callable const&, Variant const*, int, bool) at /godot/core/object/message_queue.cpp:219
[10] 5620c190f17b (main+69ea17b) - CallQueue::flush() at /godot/core/object/message_queue.cpp:268
[11] 5620bb7cbe02 (main+8a6e02) - Main::cleanup(bool) at /godot/main/main.cpp:5253
[12] 5620bb6d379a (main+7ae79a) - main at /godot/platform/linuxbsd/godot_linuxbsd.cpp:128
[13] 7da8ae7f21ca (libc.so.6+2a1ca) - /lib/x86_64-linux-gnu/libc.so.6(+0x2a1ca) [0x7da8ae7f21ca]
[14] 7da8ae7f228b (libc.so.6+2a28b) - /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x8b) [0x7da8ae7f228b]
[15] 5620bb6b2895 (main+78d895) - _start at ??:?
-- END OF C++ BACKTRACE --
================================================================
Aborted (core dumped)