Skip to content

Commit f7fa606

Browse files
committed
test(o11y): revert OpenTelemetryMetricsFactoryTest to use mocks
1 parent 5a29bdb commit f7fa606

1 file changed

Lines changed: 10 additions & 9 deletions

File tree

sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/OpenTelemetryMetricsFactoryTest.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,17 @@ void newTracerWithSpanName_shouldCreateBaseTracer_ifMetricsRecorderIsNull() {
6969

7070
@Test
7171
void newTracerWithApiTracerContext_shouldMergeApiTracerContext() {
72-
LibraryMetadata metadata =
73-
LibraryMetadata.newBuilder().setArtifactName("gax-java").setVersion("1.0").build();
74-
ApiTracerContext clientLevelTracerContext =
75-
ApiTracerContext.newBuilder().setLibraryMetadata(metadata).build();
76-
ApiTracerContext methodLevelTracerContext =
77-
ApiTracerContext.newBuilder().setLibraryMetadata(LibraryMetadata.empty()).build();
78-
79-
ApiTracerFactory factoryWithContext = tracerFactory.withContext(clientLevelTracerContext);
80-
ApiTracer actual = factoryWithContext.newTracer(mock(ApiTracer.class), methodLevelTracerContext);
72+
ApiTracerContext clientLevelTracerContext = mock(ApiTracerContext.class, RETURNS_DEEP_STUBS);
73+
ApiTracerContext methodLevelTracerContext = mock(ApiTracerContext.class);
74+
when(clientLevelTracerContext.libraryMetadata().artifactName()).thenReturn("gax-java");
75+
when(clientLevelTracerContext.libraryMetadata().isEmpty()).thenReturn(false);
76+
when(clientLevelTracerContext.merge(methodLevelTracerContext))
77+
.thenReturn(clientLevelTracerContext);
78+
79+
tracerFactory.withContext(clientLevelTracerContext);
80+
ApiTracer actual = tracerFactory.newTracer(mock(ApiTracer.class), methodLevelTracerContext);
8181

82+
verify(clientLevelTracerContext).merge(methodLevelTracerContext);
8283
assertThat(actual).isInstanceOf(OpenTelemetryMetricsTracer.class);
8384
}
8485

0 commit comments

Comments
 (0)