ci(bigquery): discovery.yaml workflow fails during npm run fix due to missing root dependencies

[westarle]

Please make sure you have searched for information in the following guides.

• Search the issues already opened: https://github.com/GoogleCloudPlatform/google-cloud-node/issues
• Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js
• Check our Troubleshooting guide: https://github.com/googleapis/google-cloud-node/blob/main/docs/troubleshooting.md
• Check our FAQ: https://github.com/googleapis/google-cloud-node/blob/main/docs/faq.md
• Check our libraries HOW-TO: https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.md
• Check out our authentication guide: https://github.com/googleapis/google-auth-library-nodejs
• Check out handwritten samples for many of our APIs: https://github.com/GoogleCloudPlatform/nodejs-docs-samples
• Check the API's issue tracker: https://cloud.google.com/support/docs/issue-trackers

Library Name

google-cloud-node (CI/CD Infrastructure) / @google-cloud/bigquery

A screenshot that you have tested with "Try this API".

N/A - This is a bug with the repository's GitHub Actions CI/CD pipeline (discovery.yaml), not an API issue.

Link to the code that reproduces this issue. A link to a public Github Repository or gist with a minimal reproduction.

https://github.com/googleapis/google-cloud-node/actions/workflows/discovery.yaml (Example of a failing run: https://github.com/googleapis/google-cloud-node/actions/runs/29830371243)

A step-by-step description of how to reproduce the issue, based on the linked reproduction.

1. Navigate to the Actions tab in the google-cloud-node repository.
2. Select the Update Discovery Generated Types (discovery.yaml) workflow.
3. Observe that every scheduled run has failed for the past several months.
4. Click into any recent failed run (e.g., the run from July 21st).
5. Expand the Run cd handwritten/bigquery && npm run fix step.
6. Observe the ESLint error: ESLint couldn't find the config "./node_modules/gts" to extend from.

A clear and concise description of what the bug is, and what you expected to happen.

The discovery.yaml GitHub Action is failing consistently during the npm run fix step. It throws an ESLint configuration error because it cannot find the gts config in ./node_modules/gts. This happens because the workflow only runs npm install inside the handwritten/bigquery directory, leaving the repository root node_modules empty. When ESLint runs, it reads the root .eslintrc.json, tries to resolve ./node_modules/gts, and crashes.

I expected the discovery.yaml workflow to successfully run npm run fix, generate the updated Discovery types, and open a pull request titled chore: update types from Discovery.

Proposed Fix: Add a step to run npm install at the repository root before running the fix command in the bigquery directory

A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

The purpose of the discovery.yaml workflow is to automate the generation of Discovery types for handwritten libraries (specifically BigQuery) so that OwlBot is no longer needed for this task. Because this workflow is broken, the types are not being updated by the workflow.

This issue is currently blocking PR #8936 (which attempts to remove OwlBot config for BigQuery). Removing OwlBot while this Action is broken would completely halt type updates for BigQuery, as OwlBot running as a post-processor on release PRs is currently the only mechanism successfully updating these types.

[westarle]

While BigQuery has its own local .eslintrc.json and .eslintignore, ESLint uses a cascading configuration system. It reads the local config in handwritten/bigquery/, but because that local config doesn't have "root": true, ESLint continues walking up the directory tree and also reads the common .eslintrc.json at the root of the google-cloud-node monorepo.

The root .eslintrc.json tells ESLint to look for ./node_modules/gts. Because discovery.yaml only runs npm install inside the bigquery folder and not at the root, the root node_modules is empty, and ESLint crashes when it tries to combine the synced local config with the common root config!