Skip to content

Commit 32ba5df

Browse files
committed
tests: add github action for conformance test
1 parent 36eaa3a commit 32ba5df

1 file changed

Lines changed: 9 additions & 46 deletions

File tree

packages/google-cloud-bigtable/noxfile.py

Lines changed: 9 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -296,57 +296,20 @@ def system_emulated(session):
296296
os.killpg(os.getpgid(p.pid), signal.SIGKILL)
297297

298298

299-
def conformance(session, client_type):
300-
# install dependencies
301-
constraints_path = str(
302-
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
303-
)
304-
install_unittest_dependencies(session, "-c", constraints_path)
305-
# None of the clients currently support reverse scans, execute query plan refresh, retry info, or routing cookie
306-
# See https://github.com/googleapis/python-bigtable/blob/c3ea54ee958a79959a649dce2553a84ec808b4d7/.github/workflows/conformance.yaml#L30-L35
307-
if client_type == "async":
308-
test_args = '-skip "PlanRefresh|_Reverse|_WithRetryInfo|_WithRoutingCookie"'
309-
else:
310-
test_args = '-skip "PlanRefresh|_Reverse|_WithRetryInfo|_WithRoutingCookie|_Generic_MultiStream"'
311-
with session.chdir("test_proxy"):
312-
# download the conformance test suite
313-
session.run(
314-
"bash",
315-
"-e",
316-
"run_tests.sh",
317-
external=True,
318-
env={
319-
"CLIENT_TYPE": client_type,
320-
"PYTHONUNBUFFERED": "1",
321-
"TEST_ARGS": test_args,
322-
"PROXY_PORT": "9999",
323-
},
324-
)
325-
326-
327-
# Run the system/emulator/conformance tests
299+
# Run the system/emulator tests
328300
@nox.session(py="3.12")
329301
@nox.parametrize(
330-
"test_type, client_type",
331-
[
332-
("system_default", None),
333-
("system_emulated", None),
334-
("conformance", "async"),
335-
("conformance", "sync"),
336-
("conformance", "legacy"),
337-
],
302+
"test_type",
303+
["system_default", "system_emulated"],
338304
)
339305
def system(session, test_type, client_type):
340306
"""Run the system/emulator tests."""
341-
if test_type == "conformance":
342-
conformance(session, client_type)
343-
else:
344-
# system and emulator tests
345-
test_map = {
346-
"system_default": system_default,
347-
"system_emulated": system_emulated,
348-
}
349-
test_map[test_type](session)
307+
# system and emulator tests
308+
test_map = {
309+
"system_default": system_default,
310+
"system_emulated": system_emulated,
311+
}
312+
test_map[test_type](session)
350313

351314

352315
def system_default(session):

0 commit comments

Comments
 (0)