Skip to content

Commit 9f09980

Browse files
committed
test: adds parametrization for system & system_noextras
1 parent 3df718a commit 9f09980

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

packages/bigframes/noxfile.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -358,16 +358,18 @@ def run_system(
358358

359359

360360
@nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS)
361-
def system(session: nox.sessions.Session):
361+
@nox.parametrize("test_extra", [True, False])
362+
def system(session: nox.sessions.Session, test_extra):
362363
"""Run the system test suite."""
363-
# TODO(https://github.com/googleapis/google-cloud-python/issues/16489): Restore system test once this bug is fixed
364-
# run_system(
365-
# session=session,
366-
# prefix_name="system",
367-
# test_folder=os.path.join("tests", "system", "small"),
368-
# check_cov=True,
369-
# )
370-
session.skip("Temporarily skip system test")
364+
if test_extra:
365+
run_system(
366+
session=session,
367+
prefix_name="system",
368+
test_folder=os.path.join("tests", "system", "small"),
369+
check_cov=True,
370+
)
371+
else:
372+
system_noextras(session)
371373

372374

373375
@nox.session(python=DEFAULT_PYTHON_VERSION)

0 commit comments

Comments
 (0)