Skip to content

Commit aa6e4d8

Browse files
committed
chore: adjusts type hints to account for complications with mypy part 2
1 parent fbeffee commit aa6e4d8

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

packages/bigframes/bigframes/core/compile/ibis_compiler/ibis_compiler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ def compile_sql(request: configs.CompileRequest) -> configs.CompileResult:
4949
# Can only pullup slice if we are doing ORDER BY in outermost SELECT
5050
# Need to do this before replacing unsupported ops, as that will rewrite slice ops
5151
result_node = rewrites.pull_up_limits(result_node)
52-
result_node = _replace_unsupported_ops(result_node)
53-
result_node = result_node.bottom_up(rewrites.simplify_join)
52+
result_node = cast(nodes.ResultNode, _replace_unsupported_ops(result_node))
53+
result_node = cast(nodes.ResultNode, result_node.bottom_up(rewrites.simplify_join))
5454
# prune before pulling up order to avoid unnnecessary row_number() ops
5555
result_node = cast(nodes.ResultNode, rewrites.column_pruning(result_node))
5656
result_node = rewrites.defer_order(

packages/bigframes/bigframes/core/compile/sqlglot/compiler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ def compile_sql(request: configs.CompileRequest) -> configs.CompileResult:
5353
# Can only pullup slice if we are doing ORDER BY in outermost SELECT
5454
# Need to do this before replacing unsupported ops, as that will rewrite slice ops
5555
result_node = rewrite.pull_up_limits(result_node)
56-
result_node = _replace_unsupported_ops(result_node)
57-
result_node = result_node.bottom_up(rewrite.simplify_join)
56+
result_node = typing.cast(nodes.ResultNode, _replace_unsupported_ops(result_node))
57+
result_node = typing.cast(nodes.ResultNode, result_node.bottom_up(rewrite.simplify_join))
5858
# prune before pulling up order to avoid unnnecessary row_number() ops
5959
result_node = typing.cast(nodes.ResultNode, rewrite.column_pruning(result_node))
6060
result_node = rewrite.defer_order(

packages/bigframes/bigframes/series.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2308,9 +2308,10 @@ def to_json(
23082308
)
23092309
else:
23102310
pd_series = self.to_pandas(allow_large_results=allow_large_results)
2311+
# Pandas Series.to_json only supports a subset of orients, but bigframes Series.to_json allows all of them.
23112312
return pd_series.to_json(
23122313
path_or_buf=path_or_buf,
2313-
orient=orient,
2314+
orient=orient, # type: ignore[arg-type]
23142315
lines=lines,
23152316
index=index, # type: ignore
23162317
)

0 commit comments

Comments
 (0)