fixes for mypy

Author: bshaffer

packages/help/docfx_helper.py

@@ -15,10 +15,15 @@
 import argparse
 import pathlib
 import shutil
+from typing import Any, Dict, List, Union
 import yaml
 import pypandoc
 
-def build_docfx(current_dir, repo_root, docs_map):
+def build_docfx(
+    current_dir: Union[str, pathlib.Path],
+    repo_root: Union[str, pathlib.Path],
+    docs_map: Dict[str, str],
+) -> None:
     current_dir = pathlib.Path(current_dir)
     repo_root = pathlib.Path(repo_root)
     output_dir = current_dir / "docs" / "_build"

packages/help/mypy.ini

@@ -1,5 +1,8 @@
 [mypy]
-python_version = 3.10
+python_version = 3.9
 ignore_missing_imports = True
 strict = True
+disallow_untyped_decorators = False
 show_error_codes = True
+explicit_package_bases = True
+namespace_packages = True

packages/help/noxfile.py

@@ -17,7 +17,7 @@
 import pathlib
 import nox
 
-DEFAULT_PYTHON_VERSION = "3.14"
+DEFAULT_PYTHON_VERSION = "3.12"
 ALL_PYTHON = ["3.9", "3.10", "3.11", "3.12", "3.13", "3.14"]
 CURRENT_DIRECTORY = pathlib.Path(__file__).parent.absolute()
 REPO_ROOT = CURRENT_DIRECTORY.parent.parent
@@ -43,27 +43,27 @@
 nox.options.error_on_missing_interpreters = True
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
-def lint_setup_py(session):
+def lint_setup_py(session: nox.Session) -> None:
     """Verify that setup.py is valid."""
     session.install("setuptools")
     session.run("python", "setup.py", "check", "--strict")
 
 @nox.session(python=ALL_PYTHON)
-def unit(session):
+def unit(session: nox.Session) -> None:
     """Run unit tests."""
     session.install("pytest", "pytest-cov")
     session.install("-e", ".")
     session.run("pytest", "tests")
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
-def mypy(session):
+def mypy(session: nox.Session) -> None:
     """Run mypy."""
     session.install("mypy", "types-PyYAML")
     session.install("-e", ".")
     session.run("mypy", "help", "tests", "noxfile.py", "docfx_helper.py")
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
-def prerelease_deps(session):
+def prerelease_deps(session: nox.Session) -> None:
     """Run unit tests with prerelease dependencies."""
     # Since we have no dependencies, this is just a normal unit test run
     # but with --pre enabled for any test tools.
@@ -72,21 +72,21 @@ def prerelease_deps(session):
     session.run("pytest", "tests")
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
-def core_deps_from_source(session):
+def core_deps_from_source(session: nox.Session) -> None:
     """Run unit tests with core dependencies installed from source."""
     # We don't depend on core, so we just run unit tests.
     session.install("pytest", "pytest-cov")
     session.install("-e", ".")
     session.run("pytest", "tests")
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
-def lint(session):
+def lint(session: nox.Session) -> None:
     """Run linters."""
     session.install("ruff")
     session.run("ruff", "check", ".")
 
 @nox.session(python="3.10")
-def docfx(session):
+def docfx(session: nox.Session) -> None:
     """Build the docfx yaml files for this library."""
     session.install("PyYAML", "pypandoc")
 
@@ -101,6 +101,6 @@ def docfx(session):
     session.run("python", "docfx_helper.py", *args)
 
 @nox.session(python=DEFAULT_PYTHON_VERSION)
-def docs(session):
+def docs(session: nox.Session) -> None:
     """No-op session for docs."""
     session.log("This package does not have Sphinx documentation.")

packages/help/tests/test_package.py

@@ -14,5 +14,5 @@
 
 from help import version
 
-def test_version():
+def test_version() -> None:
     assert version.__version__ is not None