Skip to content

Commit d66ac03

Browse files
committed
updates assertions to account for improved handling of parens
1 parent 91c02e7 commit d66ac03

1 file changed

Lines changed: 5 additions & 21 deletions

File tree

packages/sqlalchemy-bigquery/tests/unit/test__struct.py

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,11 @@
1919

2020
import datetime
2121

22-
import packaging.version
2322
import pytest
2423

2524
import sqlalchemy
2625

2726

28-
sqlalchemy_version = packaging.version.parse(sqlalchemy.__version__)
29-
SQL_2_0 = sqlalchemy_version >= packaging.version.parse("2.0")
30-
3127

3228
def _test_struct():
3329
from sqlalchemy_bigquery import STRUCT
@@ -98,21 +94,15 @@ def test_struct_traversal_project(faux_conn, expr, sql):
9894
[
9995
(
10096
_col()["name"] == "bob",
101-
"(`t`.`person`.name) = %(param_1:STRING)s"
102-
if not SQL_2_0
103-
else "`t`.`person`.name = %(param_1:STRING)s",
97+
"`t`.`person`.name = %(param_1:STRING)s",
10498
),
10599
(
106100
_col()["Name"] == "bob",
107-
"(`t`.`person`.Name) = %(param_1:STRING)s"
108-
if not SQL_2_0
109-
else "`t`.`person`.Name = %(param_1:STRING)s",
101+
"`t`.`person`.Name = %(param_1:STRING)s",
110102
),
111103
(
112104
_col()["NAME"] == "bob",
113-
"(`t`.`person`.NAME) = %(param_1:STRING)s"
114-
if not SQL_2_0
115-
else "`t`.`person`.NAME = %(param_1:STRING)s",
105+
"`t`.`person`.NAME = %(param_1:STRING)s",
116106
),
117107
(
118108
_col().children[0] == dict(name="foo", bdate=datetime.date(2020, 1, 1)),
@@ -126,18 +116,12 @@ def test_struct_traversal_project(faux_conn, expr, sql):
126116
),
127117
(
128118
_col().children[0]["bdate"] == datetime.date(2021, 8, 30),
129-
"(((`t`.`person`.children)[OFFSET(%(param_1:INT64)s)]).bdate)"
130-
" = %(param_2:DATE)s"
131-
if not SQL_2_0
132-
else "((`t`.`person`.children)[OFFSET(%(param_1:INT64)s)]).bdate"
119+
"((`t`.`person`.children)[OFFSET(%(param_1:INT64)s)]).bdate"
133120
" = %(param_2:DATE)s",
134121
),
135122
(
136123
_col().children[0].bdate == datetime.date(2021, 8, 30),
137-
"(((`t`.`person`.children)[OFFSET(%(param_1:INT64)s)]).bdate)"
138-
" = %(param_2:DATE)s"
139-
if not SQL_2_0
140-
else "((`t`.`person`.children)[OFFSET(%(param_1:INT64)s)]).bdate"
124+
"((`t`.`person`.children)[OFFSET(%(param_1:INT64)s)]).bdate"
141125
" = %(param_2:DATE)s",
142126
),
143127
],

0 commit comments

Comments
 (0)