Skip to content

Commit f46b086

Browse files
committed
tests: enable system tests with/without extras
1 parent 4b77e6f commit f46b086

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

packages/bigquery-magics/noxfile.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ def unit(session, protobuf_implementation):
274274
)
275275

276276

277-
def install_systemtest_dependencies(session, *constraints):
277+
def install_systemtest_dependencies(session, *constraints, with_extras):
278278
# Use pre-release gRPC for system tests.
279279
# Exclude version 1.52.0rc1 which has a known issue.
280280
# See https://github.com/grpc/grpc/issues/32163
@@ -291,12 +291,9 @@ def install_systemtest_dependencies(session, *constraints):
291291
if SYSTEM_TEST_DEPENDENCIES:
292292
session.install("-e", *SYSTEM_TEST_DEPENDENCIES, *constraints)
293293

294-
if SYSTEM_TEST_EXTRAS_BY_PYTHON:
295-
extras = SYSTEM_TEST_EXTRAS_BY_PYTHON.get(session.python, [])
296-
elif SYSTEM_TEST_EXTRAS:
297-
extras = SYSTEM_TEST_EXTRAS
298-
else:
299-
extras = []
294+
extras = []
295+
if with_extras:
296+
extras.extend(["bqstorage", "bigframes", "geopandas"])
300297

301298
if extras:
302299
session.install("-e", f".[{','.join(extras)}]", *constraints)
@@ -305,7 +302,8 @@ def install_systemtest_dependencies(session, *constraints):
305302

306303

307304
@nox.session(python=SYSTEM_TEST_PYTHON_VERSIONS)
308-
def system(session):
305+
@nox.parametrize("with_extras", [True, False])
306+
def system(session, with_extras):
309307
"""Run the system test suite."""
310308
constraints_path = str(
311309
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"
@@ -330,7 +328,7 @@ def system(session):
330328
if not system_test_exists and not system_test_folder_exists:
331329
session.skip("System tests were not found")
332330

333-
install_systemtest_dependencies(session, "-c", constraints_path)
331+
install_systemtest_dependencies(session, constraints_path, with_extras)
334332

335333
# Run py.test against the system tests.
336334
if system_test_exists:

0 commit comments

Comments
 (0)