From 472c0a75e93d28b50fd4742ce6b03e7e3e99662e Mon Sep 17 00:00:00 2001 From: g4lb Date: Tue, 17 Nov 2026 22:03:41 +0200 Subject: [PATCH 1/2] perf(print_schema): print descriptions without the AST printer - faster print_schema --- src/graphql/utilities/print_schema.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/graphql/utilities/print_schema.py b/src/graphql/utilities/print_schema.py index 340a6675..26aa5607 100644 --- a/src/graphql/utilities/print_schema.py +++ b/src/graphql/utilities/print_schema.py @@ -5,7 +5,8 @@ from typing import TYPE_CHECKING, Any from ..language import StringValueNode, print_ast -from ..language.block_string import is_printable_as_block_string +from ..language.block_string import is_printable_as_block_string, print_block_string +from ..language.print_string import print_string from ..pyutils import inspect from ..type import ( DEFAULT_DEPRECATION_REASON, @@ -393,11 +394,12 @@ def print_description( if description is None: return "" - block_string = print_ast( - StringValueNode( - value=description, block=is_printable_as_block_string(description) - ) - ) + # Unlike GraphQL.js, we print the string directly instead of printing a + # StringValueNode, because running the AST printer for one node is costly. + if is_printable_as_block_string(description): + block_string = print_block_string(description) + else: + block_string = print_string(description) prefix = "\n" + indentation if indentation and not first_in_block else indentation From ba88d70b3dc5715356fb5db3f9d0e9ff93354180 Mon Sep 17 00:00:00 2001 From: Christoph Zwerschke Date: Tue, 17 Nov 2026 23:05:44 +0100 Subject: [PATCH 2/2] Use a conditional expression in print_description --- src/graphql/utilities/print_schema.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/graphql/utilities/print_schema.py b/src/graphql/utilities/print_schema.py index 26aa5607..e5a6a3cf 100644 --- a/src/graphql/utilities/print_schema.py +++ b/src/graphql/utilities/print_schema.py @@ -396,10 +396,12 @@ def print_description( # Unlike GraphQL.js, we print the string directly instead of printing a # StringValueNode, because running the AST printer for one node is costly. - if is_printable_as_block_string(description): - block_string = print_block_string(description) - else: - block_string = print_string(description) + # Keep this in sync with print_string_value in the printer. + block_string = ( + print_block_string(description) + if is_printable_as_block_string(description) + else print_string(description) + ) prefix = "\n" + indentation if indentation and not first_in_block else indentation