Add custom valid values constructors to remaining enum characteristics (#163)

Add a constructor taking the valid values as first parameter to 35 enum
characteristics, following ProgrammableSwitchEventCharacteristic. The
existing constructors delegate with all enum values, so their serialized
output is unchanged. Two-value sensor and status flags are left as is.

Author: udaw

CHANGES.md

@@ -1,3 +1,6 @@
+# HAP-Java 2.0.10
+* Add constructors with a custom list of valid values to the remaining enum characteristics (except two-value sensor and status flags) [#163](https://github.com/hap-java/HAP-Java/issues/163)
+
 # HAP-Java 2.0.9
 * Fix Set Duration and Remaining Duration characteristics to advertise format `uint32` instead of `int` [#202](https://github.com/hap-java/HAP-Java/issues/202)
 * Stop logging the SRP shared secret, derived key and M5 message data during pairing at DEBUG level

src/main/java/io/github/hapjava/characteristics/impl/airpurifier/CurrentAirPurifierCharacteristic.java

@@ -18,10 +18,18 @@ public CurrentAirPurifierCharacteristic(
       Supplier<CompletableFuture<CurrentAirPurifierStateEnum>> getter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
+    this(CurrentAirPurifierStateEnum.values(), getter, subscriber, unsubscriber);
+  }
+
+  public CurrentAirPurifierCharacteristic(
+      CurrentAirPurifierStateEnum[] validValues,
+      Supplier<CompletableFuture<CurrentAirPurifierStateEnum>> getter,
+      Consumer<HomekitCharacteristicChangeCallback> subscriber,
+      Runnable unsubscriber) {
     super(
         "000000A9-0000-1000-8000-0026BB765291",
         "current air purifier state",
-        CurrentAirPurifierStateEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.empty(),
         Optional.of(subscriber),

src/main/java/io/github/hapjava/characteristics/impl/airpurifier/TargetAirPurifierStateCharacteristic.java

@@ -20,10 +20,19 @@ public TargetAirPurifierStateCharacteristic(
       ExceptionalConsumer<TargetAirPurifierStateEnum> setter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
+    this(TargetAirPurifierStateEnum.values(), getter, setter, subscriber, unsubscriber);
+  }
+
+  public TargetAirPurifierStateCharacteristic(
+      TargetAirPurifierStateEnum[] validValues,
+      Supplier<CompletableFuture<TargetAirPurifierStateEnum>> getter,
+      ExceptionalConsumer<TargetAirPurifierStateEnum> setter,
+      Consumer<HomekitCharacteristicChangeCallback> subscriber,
+      Runnable unsubscriber) {
     super(
         "000000A8-0000-1000-8000-0026BB765291",
         "Air purifier state",
-        TargetAirPurifierStateEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.of(setter),
         Optional.of(subscriber),

src/main/java/io/github/hapjava/characteristics/impl/airquality/AirQualityCharacteristic.java

@@ -16,10 +16,18 @@ public AirQualityCharacteristic(
       Supplier<CompletableFuture<AirQualityEnum>> getter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
+    this(AirQualityEnum.values(), getter, subscriber, unsubscriber);
+  }
+
+  public AirQualityCharacteristic(
+      AirQualityEnum[] validValues,
+      Supplier<CompletableFuture<AirQualityEnum>> getter,
+      Consumer<HomekitCharacteristicChangeCallback> subscriber,
+      Runnable unsubscriber) {
     super(
         "00000095-0000-1000-8000-0026BB765291",
         "air quality",
-        AirQualityEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.empty(),
         Optional.of(subscriber),

src/main/java/io/github/hapjava/characteristics/impl/battery/ChargingStateCharacteristic.java

@@ -17,10 +17,18 @@ public ChargingStateCharacteristic(
       Supplier<CompletableFuture<ChargingStateEnum>> getter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
+    this(ChargingStateEnum.values(), getter, subscriber, unsubscriber);
+  }
+
+  public ChargingStateCharacteristic(
+      ChargingStateEnum[] validValues,
+      Supplier<CompletableFuture<ChargingStateEnum>> getter,
+      Consumer<HomekitCharacteristicChangeCallback> subscriber,
+      Runnable unsubscriber) {
     super(
         "0000008F-0000-1000-8000-0026BB765291",
         "Charging state",
-        ChargingStateEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.empty(),
         Optional.of(subscriber),

src/main/java/io/github/hapjava/characteristics/impl/common/ActiveCharacteristic.java

@@ -19,10 +19,19 @@ public ActiveCharacteristic(
       ExceptionalConsumer<ActiveEnum> setter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
+    this(ActiveEnum.values(), getter, setter, subscriber, unsubscriber);
+  }
+
+  public ActiveCharacteristic(
+      ActiveEnum[] validValues,
+      Supplier<CompletableFuture<ActiveEnum>> getter,
+      ExceptionalConsumer<ActiveEnum> setter,
+      Consumer<HomekitCharacteristicChangeCallback> subscriber,
+      Runnable unsubscriber) {
     super(
         "000000B0-0000-1000-8000-0026BB765291",
         "Active",
-        ActiveEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.of(setter),
         Optional.of(subscriber),

src/main/java/io/github/hapjava/characteristics/impl/common/ProgramModeCharacteristic.java

@@ -16,10 +16,18 @@ public ProgramModeCharacteristic(
       Supplier<CompletableFuture<ProgramModeEnum>> getter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
+    this(ProgramModeEnum.values(), getter, subscriber, unsubscriber);
+  }
+
+  public ProgramModeCharacteristic(
+      ProgramModeEnum[] validValues,
+      Supplier<CompletableFuture<ProgramModeEnum>> getter,
+      Consumer<HomekitCharacteristicChangeCallback> subscriber,
+      Runnable unsubscriber) {
     super(
         "000000D1-0000-1000-8000-0026BB765291",
         "Program Mode",
-        ProgramModeEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.empty(),
         Optional.of(subscriber),

src/main/java/io/github/hapjava/characteristics/impl/common/ServiceLabelNamespaceCharacteristic.java

@@ -13,10 +13,16 @@ public class ServiceLabelNamespaceCharacteristic
     extends EnumCharacteristic<ServiceLabelNamespaceEnum> {
   public ServiceLabelNamespaceCharacteristic(
       Supplier<CompletableFuture<ServiceLabelNamespaceEnum>> getter) {
+    this(ServiceLabelNamespaceEnum.values(), getter);
+  }
+
+  public ServiceLabelNamespaceCharacteristic(
+      ServiceLabelNamespaceEnum[] validValues,
+      Supplier<CompletableFuture<ServiceLabelNamespaceEnum>> getter) {
     super(
         "000000CD-0000-1000-8000-0026BB765291",
         "service label namespace",
-        ServiceLabelNamespaceEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.empty(),
         Optional.empty(),

src/main/java/io/github/hapjava/characteristics/impl/fan/CurrentFanStateCharacteristic.java

@@ -19,10 +19,18 @@ public CurrentFanStateCharacteristic(
       Supplier<CompletableFuture<CurrentFanStateEnum>> getter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
+    this(CurrentFanStateEnum.values(), getter, subscriber, unsubscriber);
+  }
+
+  public CurrentFanStateCharacteristic(
+      CurrentFanStateEnum[] validValues,
+      Supplier<CompletableFuture<CurrentFanStateEnum>> getter,
+      Consumer<HomekitCharacteristicChangeCallback> subscriber,
+      Runnable unsubscriber) {
     super(
         "000000AF-0000-1000-8000-0026BB765291",
         "Current Fan State",
-        CurrentFanStateEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.empty(),
         Optional.of(subscriber),

src/main/java/io/github/hapjava/characteristics/impl/fan/LockPhysicalControlsCharacteristic.java

@@ -18,10 +18,19 @@ public LockPhysicalControlsCharacteristic(
       ExceptionalConsumer<LockPhysicalControlsEnum> setter,
       Consumer<HomekitCharacteristicChangeCallback> subscriber,
       Runnable unsubscriber) {
+    this(LockPhysicalControlsEnum.values(), getter, setter, subscriber, unsubscriber);
+  }
+
+  public LockPhysicalControlsCharacteristic(
+      LockPhysicalControlsEnum[] validValues,
+      Supplier<CompletableFuture<LockPhysicalControlsEnum>> getter,
+      ExceptionalConsumer<LockPhysicalControlsEnum> setter,
+      Consumer<HomekitCharacteristicChangeCallback> subscriber,
+      Runnable unsubscriber) {
     super(
         "000000A7-0000-1000-8000-0026BB765291",
         "Physical Locks",
-        LockPhysicalControlsEnum.values(),
+        validValues,
         Optional.of(getter),
         Optional.of(setter),
         Optional.of(subscriber),