BUG/MINOR: disallow whitespace-malformatted subjects

aiharos · aiharos · commit 683a3febea66 · 2021-03-17T15:19:10.000+01:00
diff --git a/check-commit/check.go b/check-commit/check.go
@@ -83,7 +83,7 @@ func checkSubjectText(subject string) error {
 	subjectPartsLen := len(subjectParts)
 
 	if subject != strings.Join(subjectParts, " ") {
-		log.Printf("malformatted subject string (trailing or double spaces?): '%s'\n", subject)
+		return fmt.Errorf("malformatted subject string (trailing or double spaces?): '%s' (%w)", subject, ErrSubjectMessageFormat)
 	}
 
 	if subjectPartsLen < minSubjectParts || subjectPartsLen > maxSubjectParts {

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ func checkSubjectText(subject string) error {`
`83`	`83`	`subjectPartsLen := len(subjectParts)`
`84`	`84`
`85`	`85`	`if subject != strings.Join(subjectParts, " ") {`
`86`		`- log.Printf("malformatted subject string (trailing or double spaces?): '%s'\n", subject)`
	`86`	`+ return fmt.Errorf("malformatted subject string (trailing or double spaces?): '%s' (%w)", subject, ErrSubjectMessageFormat)`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`if subjectPartsLen < minSubjectParts \|\| subjectPartsLen > maxSubjectParts {`