BUG/MINOR: sd: enforcing context timeout when interacting with AWS endpoints

Signed-off-by: Dario Tranchitella <dtranchitella@haproxy.com>

Author: prometherion

discovery/aws_service_discovery_instance.go

@@ -237,9 +237,12 @@ func (a *awsInstance) setAPIClient() (*ec2.Client, error) {
 }
 
 func (a *awsInstance) updateServices(api *ec2.Client) (err error) {
+	ctx, cancel := context.WithTimeout(a.ctx, a.timeout)
+	defer cancel()
+
 	var io *ec2.DescribeInstancesOutput
 
-	io, err = api.DescribeInstances(a.ctx, &ec2.DescribeInstancesInput{
+	io, err = api.DescribeInstances(ctx, &ec2.DescribeInstancesInput{
 		Filters: append([]types.Filter{
 			{
 				Name:   aws.String("tag-key"),
@@ -290,7 +293,7 @@ func (a *awsInstance) updateServices(api *ec2.Client) (err error) {
 
 	if len(a.params.Denylist) > 0 {
 		// AWS API doesn't provide negative filter search, so doing on our own
-		io, err = api.DescribeInstances(a.ctx, &ec2.DescribeInstancesInput{
+		io, err = api.DescribeInstances(ctx, &ec2.DescribeInstancesInput{
 			Filters: a.filterConverter(a.params.Denylist),
 		})
 		if err == nil {