CLEANUP/MEDIUM: lint: upgrade linter and fix linting errors

Author: mjuraga

.golangci.yml

@@ -1,86 +1,112 @@
-linters-settings:
-  govet:
-    shadow: true
-  golint:
-    min-confidence: 0
-  gocyclo:
-    min-complexity: 42
-  cyclop:
-    max-complexity: 42
-  maligned:
-    suggest-new: true
-  dupl:
-    threshold: 200
-  goconst:
-    min-len: 2
-    min-occurrences: 2
-  revive:
-    rules:
-      - name: var-naming
-        severity: warning
-        disabled: true
+version: "2"
 linters:
-  enable-all: true
+  default: all
   disable:
+    - containedctx
+    - contextcheck
+    - depguard
     - dupl
+    - err113
+    - errcheck
+    - errorlint
     - exhaustive
+    - exhaustruct
+    - forbidigo
+    - forcetypeassert
+    - funcorder
     - funlen
-    - gci
     - gochecknoglobals
     - gocognit
     - goconst
+    - gocritic
     - gocyclo
+    - godoclint
     - godot
+    - godox
+    - gomoddirectives
+    - ireturn
     - lll
+    - mnd
+    - nakedret
     - nestif
     - nlreturn
-    - wrapcheck
-    - wsl
-    - nakedret
-    - paralleltest
-    - testpackage
-    - varnamelen
-    - exhaustruct
-    - nonamedreturns
-    - forcetypeassert
-    - rowserrcheck #rowserrcheck is disabled because of generics
-    - sqlclosecheck #rowserrcheck is disabled because of generics
-    - wastedassign #rowserrcheck is disabled because of generics
-    - ireturn
-    - tagliatelle
     - noctx
-    - errorlint
-    - contextcheck
-    - godox
-    - containedctx
-    - unused
-    - unparam
+    - noinlineerr
+    - nonamedreturns
+    - paralleltest
     - prealloc
-    - forbidigo
-    - errcheck
-    - gocritic
-    - tagalign
-    - depguard
-    - mnd
-    - err113
-    - tenv # deprecated
     - recvcheck
-
-issues:
-  exclude:
-    # bugs of typecheck linter
-    - "undeclared name: `shellquote`"
-    - 'github.com/kballard/go-shellquote" imported but not used'
-    - 'github.com/haproxytech/client-native/v5/config-parser/types" imported but not used'
-  exclude-rules:
-    - linters:
-        - staticcheck
-      text: "duplicate struct tag"
-    - linters:
-        - gosec
-      text: "G[501]"
-    - linters:
-        - gosec
-      text: "G[404]"
-  exclude-dirs:
-    - test
+    - rowserrcheck
+    - sqlclosecheck
+    - tagalign
+    - tagliatelle
+    - testpackage
+    - unparam
+    - unused
+    - varnamelen
+    - wastedassign
+    - wrapcheck
+    - wsl
+    - wsl_v5
+  settings:
+    cyclop:
+      max-complexity: 42
+    dupl:
+      threshold: 200
+    goconst:
+      min-len: 2
+      min-occurrences: 2
+    gocyclo:
+      min-complexity: 42
+    revive:
+      rules:
+        - name: var-naming
+          severity: warning
+          disabled: true
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - govet
+          - whitespace
+          - gosmopolitan
+          - cyclop
+          - maintidx
+        path: metrics/logs/inputs/parsers/
+      - linters:
+          - staticcheck
+        text: duplicate struct tag
+      - linters:
+          - gosec
+        text: G[501]
+      - linters:
+          - gosec
+        text: G[404]
+      - path: (.+)\.go$
+        text: 'undeclared name: `shellquote`'
+      - path: (.+)\.go$
+        text: github.com/kballard/go-shellquote" imported but not used
+      - path: (.+)\.go$
+        text: github.com/haproxytech/client-native/v6/config-parser/types" imported but not used
+    paths:
+      - test
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - gofumpt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - test
+      - third_party$
+      - builtin$
+      - examples$

adapters/adapters.go

@@ -85,7 +85,7 @@ func RecoverMiddleware(logger *log.Logger) func(h http.Handler) http.Handler {
 				if err := recover(); err != nil {
 					frames := callers()
 
-					fields := make(map[string]interface{})
+					fields := make(map[string]any)
 					fields["stack_trace"] = frames.String()
 					logger.WithFieldsf(fields, log.ErrorLevel, "Panic %v", err)
 

client-native/cn.go

@@ -45,10 +45,7 @@ func ConfigureConfigurationClient(haproxyOptions dataplaneapi_config.HAProxyConf
 
 	p := confClient.Parser()
 	comments, err := p.Get(parser.Comments, parser.CommentsSectionName, "#")
-	insertDisclaimer := false
-	if err != nil {
-		insertDisclaimer = true
-	}
+	insertDisclaimer := err != nil
 	data, ok := comments.([]types.Comments)
 	if !ok {
 		insertDisclaimer = true

cmd/dataplaneapi/main.go

@@ -207,7 +207,7 @@ func startServer(cfg *configuration.Configuration, cancelDebugServer context.Can
 	api.BasicAuthenticator = func(authentication security.UserPassAuthentication) runtime.Authenticator {
 		// if mTLS is enabled with backing Certificate Authority, skipping basic authentication
 		if len(server.TLSCACertificate) > 0 && server.TLSPort > 0 {
-			return runtime.AuthenticatorFunc(func(i interface{}) (bool, interface{}, error) {
+			return runtime.AuthenticatorFunc(func(i any) (bool, any, error) {
 				return true, "", nil
 			})
 		}

cmd/govulncheck-report/main.go

@@ -70,17 +70,14 @@ func main() {
 		}
 		currentBranch = string(out)
 	}
-	slog.Info("Current branch: " + currentBranch)
+	slog.Info("Current branch: " + currentBranch) //nolint:gosec // log message from trusted CI environment variables
 
 	cmd := exec.Command("govulncheck", "./...")
 	out, _ := cmd.Output()
 
 	vulnMessage := string(out)
 	fmt.Println(vulnMessage)
-	noVuln := false
-	if !strings.Contains(vulnMessage, "Vulnerability #") {
-		noVuln = true
-	}
+	noVuln := !strings.Contains(vulnMessage, "Vulnerability #")
 
 	if currentBranch == "" {
 		if strings.Contains(vulnMessage, "Vulnerability #") {
@@ -138,9 +135,9 @@ func main() {
 }
 
 func createIssue(baseURL, token, projectID string, title, commentBody string) {
-	slog.Info("Active issue with title '" + title + "' not found in project " + projectID)
+	slog.Info("Active issue with title '" + title + "' not found in project " + projectID) //nolint:gosec // log message from trusted CI environment variables
 	// Create the issue here
-	issueData := map[string]interface{}{
+	issueData := map[string]any{
 		"title":       title,
 		"description": commentBody,
 		"labels":      "bot,critical",
@@ -188,7 +185,7 @@ func closeTheIssue(baseURL, token, projectID string, issueIID int, commentBody s
 	addCommentToIssue(baseURL, token, projectID, issueIID, commentBody)
 
 	client := &http.Client{}
-	issueData := map[string]interface{}{
+	issueData := map[string]any{
 		"state_event": "close",
 	}
 	issueDataBytes, err := json.Marshal(issueData)
@@ -230,7 +227,7 @@ func closeTheIssue(baseURL, token, projectID string, issueIID int, commentBody s
 
 func addCommentToIssue(baseURL, token, projectID string, issueIID int, commentBody string) {
 	client := &http.Client{}
-	noteData := map[string]interface{}{
+	noteData := map[string]any{
 		"body": commentBody,
 	}
 	noteDataBytes, err := json.Marshal(noteData)

configuration/bool.go

@@ -42,7 +42,7 @@ func (s *AtomicBool) String() string {
 	return "false"
 }
 
-func (s *AtomicBool) UnmarshalYAML(unmarshal func(interface{}) error) error {
+func (s *AtomicBool) UnmarshalYAML(unmarshal func(any) error) error {
 	var buf bool
 	err := unmarshal(&buf)
 	if err != nil {
@@ -53,6 +53,6 @@ func (s *AtomicBool) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	return nil
 }
 
-func (s AtomicBool) MarshalYAML() (interface{}, error) {
+func (s AtomicBool) MarshalYAML() (any, error) {
 	return s.Load(), nil
 }

configuration/configuration.go

@@ -247,7 +247,7 @@ func (c *Configuration) Load() error {
 }
 
 func (c *Configuration) LoadRuntimeVars(swaggerJSON json.RawMessage, host string, port int) error {
-	var m map[string]interface{}
+	var m map[string]any
 	json := jsoniter.ConfigCompatibleWithStandardLibrary
 	err := json.Unmarshal(swaggerJSON, &m)
 	if err != nil {

configuration/int.go

@@ -40,7 +40,7 @@ func (s *AtomicInt) String() string {
 	return strconv.Itoa(s.Load())
 }
 
-func (s *AtomicInt) UnmarshalYAML(unmarshal func(interface{}) error) error {
+func (s *AtomicInt) UnmarshalYAML(unmarshal func(any) error) error {
 	var buf int
 	err := unmarshal(&buf)
 	if err != nil {
@@ -51,6 +51,6 @@ func (s *AtomicInt) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	return nil
 }
 
-func (s AtomicInt) MarshalYAML() (interface{}, error) {
+func (s AtomicInt) MarshalYAML() (any, error) {
 	return s.Load(), nil
 }

configuration/map_sync.go

@@ -139,10 +139,7 @@ func equalSomeEntries(fEntries, rEntries models.MapEntries, index ...int) bool {
 		maxNo = l
 	}
 
-	maxRandom := 10
-	if maxNo < 10 {
-		maxRandom = maxNo
-	}
+	maxRandom := min(10, maxNo)
 
 	for range maxRandom {
 		// There's no need for strong number generation, here, just need for performance

configuration/string.go

@@ -39,7 +39,7 @@ func (s *AtomicString) String() string {
 	return s.Load()
 }
 
-func (s *AtomicString) UnmarshalYAML(unmarshal func(interface{}) error) error {
+func (s *AtomicString) UnmarshalYAML(unmarshal func(any) error) error {
 	var buf string
 	err := unmarshal(&buf)
 	if err != nil {
@@ -50,6 +50,6 @@ func (s *AtomicString) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	return nil
 }
 
-func (s AtomicString) MarshalYAML() (interface{}, error) {
+func (s AtomicString) MarshalYAML() (any, error) {
 	return s.Load(), nil
 }