Added tests for district and subDistrict

Author: billinghamj

tests/data/districts.json

@@ -0,0 +1,68 @@
+{
+	"tests" : [
+		{
+			"base" : "L27 8XY",
+			"expected" : "L27"
+		},
+		{
+			"base" : "NR10 3EZ",
+			"expected" : "NR10"
+		},
+		{
+			"base" : "RG4 5AY",
+			"expected" : "RG4"
+		},
+		{
+			"base" : "NE69 7AW",
+			"expected" : "NE69"
+		},
+		{
+			"base" : "SE23 2NF",
+			"expected" : "SE23"
+		},
+		{
+			"base" : "BT35 8GE",
+			"expected" : "BT35"
+		},
+		{
+			"base" : "L278XY",
+			"expected" : "L27"
+		},
+		{
+			"base" : "NR103EZ",
+			"expected" : "NR10"
+		},
+		{
+			"base" : "RG45AY",
+			"expected" : "RG4"
+		},
+		{
+			"base" : "NE697AW",
+			"expected" : "NE69"
+		},
+		{
+			"base" : "SE232NF",
+			"expected" : "SE23"
+		},
+		{
+			"base" : "BT358GE",
+			"expected" : "BT35"
+		},
+		{
+			"base" : "EC1A 1BB",
+			"expected" : "EC1"
+		},
+		{
+			"base" : "W1A0AX",
+			"expected" : "W1"
+		},
+		{
+			"base" : "NW1W1AA",
+			"expected" : "NW1"
+		},
+		{
+			"base" : "N1C 0AB",
+			"expected" : "N1"
+		}
+	]
+}

tests/data/sub-districts.json

@@ -0,0 +1,68 @@
+{
+	"tests" : [
+		{
+			"base" : "L27 8XY",
+			"expected" : null
+		},
+		{
+			"base" : "NR10 3EZ",
+			"expected" : null
+		},
+		{
+			"base" : "RG4 5AY",
+			"expected" : null
+		},
+		{
+			"base" : "NE69 7AW",
+			"expected" : null
+		},
+		{
+			"base" : "SE23 2NF",
+			"expected" : null
+		},
+		{
+			"base" : "BT35 8GE",
+			"expected" : null
+		},
+		{
+			"base" : "L278XY",
+			"expected" : null
+		},
+		{
+			"base" : "NR103EZ",
+			"expected" : null
+		},
+		{
+			"base" : "RG45AY",
+			"expected" : null
+		},
+		{
+			"base" : "NE697AW",
+			"expected" : null
+		},
+		{
+			"base" : "SE232NF",
+			"expected" : null
+		},
+		{
+			"base" : "BT358GE",
+			"expected" : null
+		},
+		{
+			"base" : "EC1A 1BB",
+			"expected" : "EC1A"
+		},
+		{
+			"base" : "W1A0AX",
+			"expected" : "W1A"
+		},
+		{
+			"base" : "NW1W1AA",
+			"expected" : "NW1W"
+		},
+		{
+			"base" : "N1C 0AB",
+			"expected" : "N1C"
+		}
+	]
+}

tests/exhaustive_unit.js

@@ -135,6 +135,54 @@ describe("Exhaustive postcode test", function () {
 			done();
 		});
 	});
+	describe("District parsing", function () {
+		it("should return the correct district", function (done) {
+			this.timeout(60000);
+			testData.forEach(function (testPostcode) {
+				var pc = testPostcode[0],
+						postcode = new Postcode(pc),
+						downcasePostcode = new Postcode(pc.toLowerCase()),
+						unspacedPostcode = new Postcode(pc.replace(/\s/, "")),
+						testDistrict;
+				if (pc.length === 7) {
+					// Since this isn't normalised in dataset, best we can do is see if normalised data matches
+					assert.equal(postcode.district(), downcasePostcode.district());
+					assert.equal(postcode.district(), unspacedPostcode.district());
+				} else {
+					// Any space indicates incode/outcode
+					testDistrict = pc.match(/\s.*/)[0].replace(/\s/, "");
+					assert.equal(postcode.district(), testDistrict);
+					assert.equal(downcasePostcode.district(), testDistrict);
+					assert.equal(unspacedPostcode.district(), testDistrict);
+				}
+			});
+			done();
+		});
+	});
+	describe("Sub-district parsing", function () {
+		it("should return the correct sub-district", function (done) {
+			this.timeout(60000);
+			testData.forEach(function (testPostcode) {
+				var pc = testPostcode[0],
+						postcode = new Postcode(pc),
+						downcasePostcode = new Postcode(pc.toLowerCase()),
+						unspacedPostcode = new Postcode(pc.replace(/\s/, "")),
+						testSubDistrict;
+				if (pc.length === 7) {
+					// Since this isn't normalised in dataset, best we can do is see if normalised data matches
+					assert.equal(postcode.subDistrict(), downcasePostcode.subDistrict());
+					assert.equal(postcode.subDistrict(), unspacedPostcode.subDistrict());
+				} else {
+					// Any space indicates incode/outcode
+					testSubDistrict = pc.match(/\s.*/)[0].replace(/\s/, "");
+					assert.equal(postcode.subDistrict(), testSubDistrict);
+					assert.equal(downcasePostcode.subDistrict(), testSubDistrict);
+					assert.equal(unspacedPostcode.subDistrict(), testSubDistrict);
+				}
+			});
+			done();
+		});
+	});
 	describe("Sector parsing", function () {
 		it("should return the correct sector", function (done) {
 			this.timeout(60000);

tests/unit.js

@@ -119,6 +119,44 @@ describe("Area parsing", function () {
 	});
 });
 
+describe("District parsing", function () {
+	before(function (done) {
+		testData = fs.readFile(path.join(dataDir, "districts.json"), function (error, data) {
+			if (error) throw error;
+			testData = JSON.parse(data);
+			done();
+		});
+	});
+
+	it ("should correctly parse districts", function () {
+		testData.tests.forEach(function (elem) {
+			assert.equal(new Postcode(elem.base).district(), elem.expected);
+		});
+	});
+	it ("should return null if invalid postcode", function () {
+		assert.isNull(new Postcode("Definitely bogus").district());
+	});
+});
+
+describe("Sub-district parsing", function () {
+	before(function (done) {
+		testData = fs.readFile(path.join(dataDir, "sub-districts.json"), function (error, data) {
+			if (error) throw error;
+			testData = JSON.parse(data);
+			done();
+		});
+	});
+
+	it ("should correctly parse sub-districts", function () {
+		testData.tests.forEach(function (elem) {
+			assert.equal(new Postcode(elem.base).subDistrict(), elem.expected);
+		});
+	});
+	it ("should return null if invalid postcode", function () {
+		assert.isNull(new Postcode("Definitely bogus").subDistrict());
+	});
+});
+
 describe("Sector parsing", function () {
 	before(function (done) {
 		testData = fs.readFile(path.join(dataDir, "sectors.json"), function (error, data) {