diff --git a/.github/workflows/ai_pr_review.yml b/.github/workflows/ai_pr_review.yml index f9748b84..0ac8c426 100644 --- a/.github/workflows/ai_pr_review.yml +++ b/.github/workflows/ai_pr_review.yml @@ -516,7 +516,7 @@ jobs: sandbox: read-only safety-strategy: drop-sudo # Recommended by OpenAI for review quality/consistency: - model: gpt-5.4 + model: gpt-5.5 effort: xhigh - name: Post PR comment (new on every event except initial open) diff --git a/diff_diff/estimators.py b/diff_diff/estimators.py index 8c71dd76..d6aac69a 100644 --- a/diff_diff/estimators.py +++ b/diff_diff/estimators.py @@ -1604,22 +1604,9 @@ def fit( # type: ignore[override] X = np.column_stack([X, working_data[cov].values.astype(float)]) var_names.append(cov) - # Add fixed effects as dummy variables. - # - # MPD's design already absorbs the time dimension via non-reference - # period dummies (the `period_` columns above) and the treatment- - # period interactions. If the caller passes the same column as a - # fixed effect (either explicitly or via the absorb -> fixed_effects - # auto-route for HC2/HC2-BM), the resulting `