Merge pull request #78 from Sandipkakadiya/review

Review

Author: Sandipkakadiya

.gitignore

@@ -32,6 +32,7 @@ web/
 getflutter-app-kit
 getflutter-web-kit
 getflutter_app
+test/.test_coverage.dart
 
 # Android related
 **/android/**/gradle-wrapper.jar

analysis_options.yaml

@@ -4,6 +4,7 @@ analyzer:
     - getflutter_app
     - getflutter-app-kit
     - getflutter-web-kit
+    - test/.test_coverage.dart
 
 linter:
   rules:
@@ -13,7 +14,7 @@ linter:
     # - always_put_required_named_parameters_first
     - always_require_non_null_named_parameters
     # - annotate_overrides
-    # required to Allow bith GFColors and Colors
+    # required to Allow both GFColors and Colors
     # - avoid_annotating_with_dynamic
     - avoid_as
     - avoid_bool_literals_in_conditional_expressions

example/lib/main.dart

@@ -67,7 +67,7 @@ class _MyHomePageState extends State<MyHomePage>
     'Xamarin2',
   ];
 
-  var rating = 3.5;
+  double rating = 3.5;
 
   @override
   Widget build(BuildContext context) => Scaffold(
@@ -79,7 +79,7 @@ class _MyHomePageState extends State<MyHomePage>
           gradient: LinearGradient(
             begin: Alignment.topRight,
             end: Alignment.bottomLeft,
-            stops: [0.1, 0.5, 0.7, 0.9],
+            stops: const [0.1, 0.5, 0.7, 0.9],
             colors: [
               Colors.teal[800],
               Colors.teal[600],
@@ -234,21 +234,21 @@ class _MyHomePageState extends State<MyHomePage>
             GFCard(
               content: Column(
                 children: <Widget>[
-                  GFTypography(
+                  const GFTypography(
                     text: 'Toast',
                     type: GFTypographyType.typo6,
                   ),
-                  SizedBox(
+                  const SizedBox(
                     height: 20,
                   ),
-                  SizedBox(
+                  const SizedBox(
                     height: 20,
                   ),
                   GFToast(
                     text: 'Happy New Year',
                     button: GFButton(
                       onPressed: () {
-                        print("dfr");
+                        print('dfr');
                       },
                       text: 'OK',
                       type: GFButtonType.outline,

lib/components/rating/gf_rating.dart

@@ -1,9 +1,9 @@
 import 'package:flutter/material.dart';
 
-typedef void RatingChangeCallback(double rating);
+typedef RatingChangeCallback = void Function(double rating);
 
 class GFRating extends StatelessWidget {
-  GFRating({
+  const GFRating({
     this.itemCount = 5,
     this.spacing = 0.0,
     this.rating = 0.0,
@@ -15,9 +15,7 @@ class GFRating extends StatelessWidget {
     this.filledIcon,
     this.halfFilledIcon,
     this.allowHalfRating = true,
-  }) {
-    assert(this.rating != null);
-  }
+  }) : assert(rating != null);
 
   /// defines total number of rating items
   final int itemCount;
@@ -61,7 +59,7 @@ class GFRating extends StatelessWidget {
         size: itemSize,
       );
     } else if (index > rating - (allowHalfRating ? 0.5 : 1.0) &&
-        index < rating) {
+        index <= rating) {
       icon = Icon(
         halfFilledIcon != null ? halfFilledIcon : Icons.star_half,
         color: color ?? Theme.of(context).primaryColor,
@@ -77,9 +75,10 @@ class GFRating extends StatelessWidget {
 
     return GestureDetector(
       onTap: () {
-        if (onRatingChanged != null) onRatingChanged(index + 1.0);
+        if (onRatingChanged != null) {
+          onRatingChanged(index + 1.0);
+        }
       },
-//      onHorizontalDragStart: ,
       child: icon,
     );
   }
@@ -88,9 +87,12 @@ class GFRating extends StatelessWidget {
   Widget build(BuildContext context) => Material(
         color: Colors.transparent,
         child: Wrap(
-            alignment: WrapAlignment.center,
-            spacing: spacing,
-            children: List.generate(
-                itemCount, (index) => buildRatingBar(context, index))),
+          alignment: WrapAlignment.center,
+          spacing: spacing,
+          children: List.generate(
+            itemCount,
+            (index) => buildRatingBar(context, index),
+          ),
+        ),
       );
 }

pubspec.lock

@@ -50,6 +50,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.1.1"
+  coverage:
+    dependency: transitive
+    description:
+      name: coverage
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.13.4"
   crypto:
     dependency: transitive
     description:
@@ -67,13 +74,48 @@ packages:
     description: flutter
     source: sdk
     version: "0.0.0"
+  glob:
+    dependency: transitive
+    description:
+      name: glob
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.2.0"
   image:
     dependency: transitive
     description:
       name: image
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.1.4"
+  js:
+    dependency: transitive
+    description:
+      name: js
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.6.1+1"
+  json_annotation:
+    dependency: transitive
+    description:
+      name: json_annotation
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "3.0.1"
+  lcov:
+    dependency: transitive
+    description:
+      name: lcov
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "5.5.0"
+  logging:
+    dependency: transitive
+    description:
+      name: logging
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.11.4"
   matcher:
     dependency: transitive
     description:
@@ -88,6 +130,27 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "1.1.8"
+  node_interop:
+    dependency: transitive
+    description:
+      name: node_interop
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.3"
+  node_io:
+    dependency: transitive
+    description:
+      name: node_io
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.0.1+2"
+  package_config:
+    dependency: transitive
+    description:
+      name: package_config
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "1.1.0"
   path:
     dependency: transitive
     description:
@@ -121,6 +184,13 @@ packages:
     description: flutter
     source: sdk
     version: "0.0.99"
+  source_maps:
+    dependency: transitive
+    description:
+      name: source_maps
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.10.8"
   source_span:
     dependency: transitive
     description:
@@ -163,6 +233,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "0.2.11"
+  test_coverage:
+    dependency: "direct dev"
+    description:
+      name: test_coverage
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "0.4.1"
   typed_data:
     dependency: transitive
     description:
@@ -177,6 +254,13 @@ packages:
       url: "https://pub.dartlang.org"
     source: hosted
     version: "2.0.8"
+  vm_service:
+    dependency: transitive
+    description:
+      name: vm_service
+      url: "https://pub.dartlang.org"
+    source: hosted
+    version: "2.3.1"
   xml:
     dependency: transitive
     description:
@@ -185,4 +269,4 @@ packages:
     source: hosted
     version: "3.5.0"
 sdks:
-  dart: ">=2.4.0 <3.0.0"
+  dart: ">=2.6.0 <3.0.0"

pubspec.yaml

@@ -15,6 +15,7 @@ dependencies:
 dev_dependencies:
   flutter_test:
     sdk: flutter
+  test_coverage: ^0.4.1
 
 flutter:
   uses-material-design: true