Skip to content

Commit bee7b05

Browse files
authored
Merge pull request #154 from itk-dev/fix/changelog-base-ref-env
Pass github.base_ref to the changelog check through env
2 parents a8942f4 + 67869d1 commit bee7b05

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ Changelog", this file is a reverse-chronological list of merged pull requests.
66

77
## Open PR's
88

9+
- [PR-154](https://github.com/itk-dev/devops_itkdev-docker/pull/154) - 2026-10-05 -
10+
Pass `github.base_ref` to the changelog workflow through `env` instead of
11+
interpolating it into the shell command
912
- [PR-153](https://github.com/itk-dev/devops_itkdev-docker/pull/153) - 2026-09-29 -
1013
Added basic template for python base projects
1114
- [PR-152](https://github.com/itk-dev/devops_itkdev-docker/pull/152) - 2026-09-15 -

‎github/workflows/changelog.yaml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,6 @@ jobs:
2424
run: git fetch
2525

2626
- name: Check that changelog has been updated.
27-
run: git diff --exit-code origin/${{ github.base_ref }} -- CHANGELOG.md && exit 1 || exit 0
27+
env:
28+
BASE_REF: ${{ github.base_ref }}
29+
run: git diff --exit-code "origin/$BASE_REF" -- CHANGELOG.md && exit 1 || exit 0

‎templates/python/.github/workflows/changelog.yaml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,6 @@ jobs:
2424
run: git fetch
2525

2626
- name: Check that changelog has been updated.
27-
run: git diff --exit-code origin/${{ github.base_ref }} -- CHANGELOG.md && exit 1 || exit 0
27+
env:
28+
BASE_REF: ${{ github.base_ref }}
29+
run: git diff --exit-code "origin/$BASE_REF" -- CHANGELOG.md && exit 1 || exit 0

0 commit comments

Comments
 (0)