From 67869d1f7c8dbd50c2cbb100d30d47eb9f42826e Mon Sep 17 00:00:00 2001 From: turegjorup Date: Mon, 5 Oct 2026 13:40:45 +0200 Subject: [PATCH] fix: pass github.base_ref to the changelog check through env --- CHANGELOG.md | 3 +++ github/workflows/changelog.yaml | 4 +++- templates/python/.github/workflows/changelog.yaml | 4 +++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f0794f..93dbf5c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,9 @@ Changelog", this file is a reverse-chronological list of merged pull requests. ## Open PR's +- [PR-154](https://github.com/itk-dev/devops_itkdev-docker/pull/154) - 2026-10-05 - + Pass `github.base_ref` to the changelog workflow through `env` instead of + interpolating it into the shell command - [PR-153](https://github.com/itk-dev/devops_itkdev-docker/pull/153) - 2026-09-29 - Added basic template for python base projects - [PR-152](https://github.com/itk-dev/devops_itkdev-docker/pull/152) - 2026-09-15 - diff --git a/github/workflows/changelog.yaml b/github/workflows/changelog.yaml index 30d63e7..54b9acb 100644 --- a/github/workflows/changelog.yaml +++ b/github/workflows/changelog.yaml @@ -24,4 +24,6 @@ jobs: run: git fetch - name: Check that changelog has been updated. - run: git diff --exit-code origin/${{ github.base_ref }} -- CHANGELOG.md && exit 1 || exit 0 + env: + BASE_REF: ${{ github.base_ref }} + run: git diff --exit-code "origin/$BASE_REF" -- CHANGELOG.md && exit 1 || exit 0 diff --git a/templates/python/.github/workflows/changelog.yaml b/templates/python/.github/workflows/changelog.yaml index 30d63e7..54b9acb 100644 --- a/templates/python/.github/workflows/changelog.yaml +++ b/templates/python/.github/workflows/changelog.yaml @@ -24,4 +24,6 @@ jobs: run: git fetch - name: Check that changelog has been updated. - run: git diff --exit-code origin/${{ github.base_ref }} -- CHANGELOG.md && exit 1 || exit 0 + env: + BASE_REF: ${{ github.base_ref }} + run: git diff --exit-code "origin/$BASE_REF" -- CHANGELOG.md && exit 1 || exit 0