Skip to content

Commit 4130f99

Browse files
committed
Test with Acorn (not Acorn-6to5) and fix issue with AssignmentPattern
Acorn-6to5 is not up-to-date. After switching to Acorn, a test failed, showing that escodegen had been improperly handling AssignmentPattern.
1 parent c6a0c12 commit 4130f99

3 files changed

Lines changed: 9 additions & 13 deletions

File tree

escodegen.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2205,7 +2205,7 @@
22052205
},
22062206

22072207
AssignmentPattern: function(expr, precedence, flags) {
2208-
return this.generateAssignment(expr.left, expr.right, expr.operator, precedence, flags);
2208+
return this.generateAssignment(expr.left, expr.right, '=', precedence, flags);
22092209
},
22102210

22112211
ObjectPattern: function (expr, precedence, flags) {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
"source-map": "~0.2.0"
4141
},
4242
"devDependencies": {
43-
"acorn-6to5": "^0.11.1-25",
43+
"acorn": "^2.7.0",
4444
"bluebird": "^2.3.11",
4545
"bower-registry-client": "^0.2.1",
4646
"chai": "^1.10.0",

test/compare-acorn-es6.js

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
'use strict';
2626

2727
var fs = require('fs'),
28-
acorn = require('acorn-6to5'),
28+
acorn = require('acorn'),
2929
escodegen = require('./loader'),
3030
chai = require('chai'),
3131
expect = chai.expect;
@@ -37,11 +37,9 @@ function test(code, expected) {
3737
StringObject = String;
3838

3939
options = {
40-
range: true,
41-
loc: false,
42-
tokens: true,
43-
raw: false,
44-
ecmaVersion: 7
40+
ranges: true,
41+
locations: false,
42+
ecmaVersion: 6
4543
};
4644

4745
tree = acorn.parse(code, options);
@@ -58,11 +56,9 @@ function testMin(code, expected) {
5856
StringObject = String;
5957

6058
options = {
61-
range: true,
62-
loc: false,
63-
tokens: true,
64-
raw: false,
65-
ecmaVersion: 7
59+
ranges: true,
60+
locations: false,
61+
ecmaVersion: 6
6662
};
6763

6864
tree = acorn.parse(code, options);

0 commit comments

Comments
 (0)