Value API: hide builtin converters

jknack · jknack · commit 3d396b132ade · 2019-09-08T21:19:17.000-03:00
diff --git a/jooby/src/main/java/io/jooby/converter/ValueConverter.java b/jooby/src/main/java/io/jooby/converter/ValueConverter.java
diff --git a/jooby/src/main/java/io/jooby/internal/ValueInjector.java b/jooby/src/main/java/io/jooby/internal/ValueInjector.java
@@ -11,8 +11,8 @@
 import io.jooby.ProvisioningException;
 import io.jooby.TypeMismatchException;
 import io.jooby.Value;
-import io.jooby.converter.ValueConverter;
-import io.jooby.converter.ValueOfConverter;
+import io.jooby.spi.ValueConverter;
+import io.jooby.internal.converter.ValueOfConverter;
 import io.jooby.internal.reflect.$Types;
 import io.jooby.spi.BeanValueConverters;
 
diff --git a/jooby/src/main/java/io/jooby/internal/converter/BigDecimalConverter.java b/jooby/src/main/java/io/jooby/internal/converter/BigDecimalConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.math.BigDecimal;
 
diff --git a/jooby/src/main/java/io/jooby/internal/converter/BigIntegerConverter.java b/jooby/src/main/java/io/jooby/internal/converter/BigIntegerConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.math.BigInteger;
 
diff --git a/jooby/src/main/java/io/jooby/internal/converter/CharsetConverter.java b/jooby/src/main/java/io/jooby/internal/converter/CharsetConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.nio.charset.Charset;
 import java.nio.charset.StandardCharsets;
diff --git a/jooby/src/main/java/io/jooby/internal/converter/DateConverter.java b/jooby/src/main/java/io/jooby/internal/converter/DateConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.time.LocalDate;
 import java.time.ZoneId;
diff --git a/jooby/src/main/java/io/jooby/internal/converter/DurationConverter.java b/jooby/src/main/java/io/jooby/internal/converter/DurationConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import com.typesafe.config.ConfigException;
 import com.typesafe.config.ConfigFactory;
diff --git a/jooby/src/main/java/io/jooby/internal/converter/EnumConverter.java b/jooby/src/main/java/io/jooby/internal/converter/EnumConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 public class EnumConverter implements ValueConverter {
   @Override public boolean supports(Class type) {
diff --git a/jooby/src/main/java/io/jooby/internal/converter/InstantConverter.java b/jooby/src/main/java/io/jooby/internal/converter/InstantConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.time.Instant;
 
diff --git a/jooby/src/main/java/io/jooby/internal/converter/LocalDateConverter.java b/jooby/src/main/java/io/jooby/internal/converter/LocalDateConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.time.Instant;
 import java.time.LocalDate;
diff --git a/jooby/src/main/java/io/jooby/internal/converter/LocalDateTimeConverter.java b/jooby/src/main/java/io/jooby/internal/converter/LocalDateTimeConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.time.Instant;
 import java.time.LocalDateTime;
diff --git a/jooby/src/main/java/io/jooby/internal/converter/PeriodConverter.java b/jooby/src/main/java/io/jooby/internal/converter/PeriodConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.time.Duration;
 import java.time.Period;
diff --git a/jooby/src/main/java/io/jooby/internal/converter/StatusCodeConverter.java b/jooby/src/main/java/io/jooby/internal/converter/StatusCodeConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import io.jooby.StatusCode;
 
diff --git a/jooby/src/main/java/io/jooby/internal/converter/TimeZoneConverter.java b/jooby/src/main/java/io/jooby/internal/converter/TimeZoneConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.util.TimeZone;
 
diff --git a/jooby/src/main/java/io/jooby/internal/converter/URIConverter.java b/jooby/src/main/java/io/jooby/internal/converter/URIConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import io.jooby.SneakyThrows;
 
diff --git a/jooby/src/main/java/io/jooby/internal/converter/UUIDConverter.java b/jooby/src/main/java/io/jooby/internal/converter/UUIDConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.util.UUID;
 
diff --git a/jooby/src/main/java/io/jooby/internal/converter/ValueOfConverter.java b/jooby/src/main/java/io/jooby/internal/converter/ValueOfConverter.java
@@ -1,5 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
 
+import io.jooby.spi.ValueConverter;
 import io.jooby.SneakyThrows;
 
 import java.lang.reflect.InvocationTargetException;
diff --git a/jooby/src/main/java/io/jooby/internal/converter/ZoneIdConverter.java b/jooby/src/main/java/io/jooby/internal/converter/ZoneIdConverter.java
@@ -1,4 +1,6 @@
-package io.jooby.converter;
+package io.jooby.internal.converter;
+
+import io.jooby.spi.ValueConverter;
 
 import java.time.ZoneId;
 
diff --git a/jooby/src/main/java/io/jooby/spi/ValueConverter.java b/jooby/src/main/java/io/jooby/spi/ValueConverter.java
@@ -0,0 +1,26 @@
+package io.jooby.spi;
+
+import javax.annotation.Nonnull;
+
+/**
+ * Value converter for string values that come from query, path, form parameters into more specific
+ * type.
+ */
+public interface ValueConverter {
+  /**
+   * True if the converter applies for the given type.
+   *
+   * @param type Conversion type.
+   * @return True if the converter applies for the given type.
+   */
+  boolean supports(@Nonnull Class type);
+
+  /**
+   * Convert string to specific type.
+   *
+   * @param type Requested type.
+   * @param value String value.
+   * @return Converted value.
+   */
+  Object convert(@Nonnull Class type, @Nonnull String value);
+}
diff --git a/jooby/src/main/resources/META-INF/services/io.jooby.converter.ValueConverter b/jooby/src/main/resources/META-INF/services/io.jooby.converter.ValueConverter
diff --git a/jooby/src/main/resources/META-INF/services/io.jooby.spi.ValueConverter b/jooby/src/main/resources/META-INF/services/io.jooby.spi.ValueConverter
@@ -0,0 +1,15 @@
+io.jooby.internal.converter.BigDecimalConverter
+io.jooby.internal.converter.BigIntegerConverter
+io.jooby.internal.converter.EnumConverter
+io.jooby.internal.converter.InstantConverter
+io.jooby.internal.converter.StatusCodeConverter
+io.jooby.internal.converter.UUIDConverter
+io.jooby.internal.converter.CharsetConverter
+io.jooby.internal.converter.ZoneIdConverter
+io.jooby.internal.converter.TimeZoneConverter
+io.jooby.internal.converter.URIConverter
+io.jooby.internal.converter.DurationConverter
+io.jooby.internal.converter.LocalDateConverter
+io.jooby.internal.converter.DateConverter
+io.jooby.internal.converter.PeriodConverter
+io.jooby.internal.converter.LocalDateTimeConverter
