- fix duplicate method name when overloading a method

- remove println statements from tests

Author: jknack

modules/jooby-apt/src/main/java/io/jooby/apt/JoobyProcessor.java

@@ -299,22 +299,51 @@ private Map<TypeElement, MvcRouter> buildRouteRegistry(
 
     // Generate unique method name by router
     for (var router : registry.values()) {
-      // Initialize with supports/create method from MvcFactory (avoid name collision)
-      var names = new HashSet<>();
-      for (var route : router.getRoutes()) {
-        if (!names.add(route.getMethodName())) {
+      // Split routes by their target generated classes to avoid false collisions
+      var restAndTrpcRoutes = router.getRoutes().stream().filter(r -> !r.isJsonRpc()).toList();
+
+      var rpcRoutes = router.getRoutes().stream().filter(MvcRoute::isJsonRpc).toList();
+
+      resolveGeneratedNames(restAndTrpcRoutes);
+      resolveGeneratedNames(rpcRoutes);
+    }
+    return registry;
+  }
+
+  private void resolveGeneratedNames(List<MvcRoute> routes) {
+    // Group by the actual target method name in the generated class
+    var grouped =
+        routes.stream()
+            .collect(
+                Collectors.groupingBy(
+                    route -> {
+                      String baseName = route.getMethodName();
+                      return route.isTrpc()
+                          ? "trpc"
+                              + Character.toUpperCase(baseName.charAt(0))
+                              + baseName.substring(1)
+                          : baseName;
+                    }));
+
+    for (var overloads : grouped.values()) {
+      if (overloads.size() == 1) {
+        // No conflict in this specific output file, use the clean original name
+        overloads.get(0).setGeneratedName(overloads.get(0).getMethodName());
+      } else {
+        // Conflict detected: generate names based on parameter types
+        for (var route : overloads) {
           var paramsString =
               route.getRawParameterTypes(true).stream()
                   .map(it -> it.substring(Math.max(0, it.lastIndexOf(".") + 1)))
                   .map(it -> Character.toUpperCase(it.charAt(0)) + it.substring(1))
                   .collect(Collectors.joining());
+
+          // A 0-arg method gets exactly the base name.
+          // Methods with args get the base name + their parameter types.
           route.setGeneratedName(route.getMethodName() + paramsString);
-        } else {
-          route.setGeneratedName(route.getMethodName());
         }
       }
     }
-    return registry;
   }
 
   /**

modules/jooby-apt/src/main/java/io/jooby/internal/apt/MvcRoute.java

@@ -83,6 +83,10 @@ public String getProjection() {
     return projection.stream().findFirst().orElse(null);
   }
 
+  public boolean isTrpc() {
+    return isTrpc;
+  }
+
   public boolean isProjection() {
     if (returnType.is(Types.PROJECTED)) {
       return false;

modules/jooby-apt/src/test/java/tests/i3863/C3863.java

@@ -5,6 +5,9 @@
  */
 package tests.i3863;
 
+import java.util.List;
+
+import io.jooby.Context;
 import io.jooby.annotation.*;
 
 @Trpc("users")
@@ -15,34 +18,31 @@ public String ping(Integer year) {
     return null;
   }
 
-  //  @Trpc.Query
-  //  public String ping() {
-  //    return null;
-  //  }
-  //
-  //  @Trpc.Query
-  //  public void clear() {
-  //
-  //  }
-  //
-  //  @Trpc.Query
-  //  public U3863 findUser(Context ctx, @PathParam long id) {
-  //    return null;
-  //  }
-  //
-  //  @Trpc.Query
-  //  public List<U3863> multipleSimpleArgs(String q, byte type) {
-  //    return null;
-  //  }
-  //
-  //  @Trpc.Query
-  //  public List<U3863> multipleComplexArguments(U3863 current, List<U3863> users) {
-  //    return null;
-  //  }
-  //
-  //  @Trpc.Mutation
-  //  public U3863 updateUser(String id, U3863 payload) {
-  //    return null;
-  //  }
+  @Trpc.Query
+  public String ping() {
+    return null;
+  }
+
+  @Trpc.Query
+  public void clear() {}
+
+  @Trpc.Query
+  public U3863 findUser(Context ctx, @PathParam long id) {
+    return null;
+  }
+
+  @Trpc.Query
+  public List<U3863> multipleSimpleArgs(String q, byte type) {
+    return null;
+  }
+
+  @Trpc.Query
+  public List<U3863> multipleComplexArguments(U3863 current, List<U3863> users) {
+    return null;
+  }
 
+  @Trpc.Mutation
+  public U3863 updateUser(String id, U3863 payload) {
+    return null;
+  }
 }

modules/jooby-apt/src/test/java/tests/i3863/Issue3863.java

@@ -5,6 +5,8 @@
  */
 package tests.i3863;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 import org.junit.jupiter.api.Test;
 
 import io.jooby.apt.ProcessorRunner;
@@ -15,7 +17,12 @@ public void shouldGenerateTrpcService() throws Exception {
     new ProcessorRunner(new C3863())
         .withSourceCode(
             source -> {
-              System.out.println(source);
+              assertThat(source)
+                  .contains("app.get(\"/trpc/users.ping\", this::trpcPingInteger);")
+                  .contains("app.get(\"/trpc/users.ping\", this::trpcPing);")
+                  .contains(
+                      "public io.jooby.trpc.TrpcResponse<java.util.List<tests.i3863.U3863>>"
+                          + " trpcMultipleSimpleArgs(io.jooby.Context ctx) throws Exception {");
             });
   }
 }

modules/jooby-apt/src/test/java/tests/i3864/C3864.java

@@ -11,8 +11,11 @@
 @JsonRpc("users")
 public class C3864 {
 
-  @JsonRpc
   public String ping(Context ctx, int year) {
     return null;
   }
+
+  public String createUser(Context ctx, String name) {
+    return null;
+  }
 }

modules/jooby-apt/src/test/java/tests/i3864/Issue3868.java

@@ -5,6 +5,8 @@
  */
 package tests.i3864;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 import org.junit.jupiter.api.Test;
 
 import io.jooby.apt.ProcessorRunner;
@@ -15,7 +17,14 @@ public void shouldGenerateJsonRpcService() throws Exception {
     new ProcessorRunner(new C3864())
         .withSourceCode(
             source -> {
-              System.out.println(source);
+              assertThat(source)
+                  .contains(
+                      "public class C3864Rpc_ implements io.jooby.jsonrpc.JsonRpcService,"
+                          + " io.jooby.Extension {")
+                  .contains("public java.util.List<String> getMethods() {")
+                  .contains(
+                      "public Object execute(io.jooby.Context ctx, io.jooby.jsonrpc.JsonRpcRequest"
+                          + " req) throws Exception {");
             });
   }
 }