Commit f0b06cf
test: replace Thread.sleep with sync primitives in tests
Replace flaky Thread.sleep calls with proper synchronization:
- SharedProcessorTest: use Semaphore(0).acquire() instead of
Thread.sleep(10s) so the worker blocks until interrupted by
shutdownNow(), making the test deterministic and instant.
- KubernetesReconcilerCreatorTest: use Wait.poll() instead of
Thread.sleep(500ms) to actively poll until the work queue is
populated, making the test faster and non-flaky.
Addresses part of #1223.
Co-Authored-By: Oz <oz-agent@warp.dev>1 parent 1c1dad0 commit f0b06cf
2 files changed
Lines changed: 9 additions & 4 deletions
File tree
- spring/src/test/java/io/kubernetes/client/spring/extended/controller
- util/src/test/java/io/kubernetes/client/informer/cache
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
194 | 196 | | |
195 | 197 | | |
196 | 198 | | |
197 | | - | |
198 | | - | |
199 | 199 | | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
200 | 203 | | |
201 | 204 | | |
202 | 205 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
69 | 70 | | |
70 | 71 | | |
71 | 72 | | |
| 73 | + | |
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
75 | | - | |
76 | | - | |
| 77 | + | |
| 78 | + | |
77 | 79 | | |
78 | 80 | | |
79 | 81 | | |
| |||
0 commit comments