Convert Pull into a command

This makes it clearer that what we have there is a command and not a
method fundamental to the Git system.

Author: carlosmn

LibGit2Sharp.Tests/NetworkFixture.cs

@@ -164,7 +164,7 @@ public void CanPull(FastForwardStrategy fastForwardStrategy)
                     }
                 };
 
-                MergeResult mergeResult = repo.Network.Pull(Constants.Signature, pullOptions);
+                MergeResult mergeResult = new Commands.Pull(repo, Constants.Signature, pullOptions).Run();
 
                 if(fastForwardStrategy == FastForwardStrategy.Default || fastForwardStrategy == FastForwardStrategy.FastForwardOnly)
                 {
@@ -197,7 +197,7 @@ public void CanPullIntoEmptyRepo()
                     b => b.UpstreamBranch = "refs/heads/master");
 
                 // Pull!
-                MergeResult mergeResult = repo.Network.Pull(Constants.Signature, new PullOptions());
+                MergeResult mergeResult = new Commands.Pull(repo, Constants.Signature, new PullOptions()).Run();
 
                 Assert.Equal(mergeResult.Status, MergeStatus.FastForward);
                 Assert.Equal(mergeResult.Commit, repo.Branches["refs/remotes/origin/master"].Tip);
@@ -224,7 +224,7 @@ public void PullWithoutMergeBranchThrows()
 
                 try
                 {
-                    repo.Network.Pull(Constants.Signature, new PullOptions());
+                    new Commands.Pull(repo, Constants.Signature, new PullOptions()).Run();
                 }
                 catch(MergeFetchHeadNotFoundException ex)
                 {

LibGit2Sharp/Commands/Pull.cs

@@ -0,0 +1,59 @@
+using System;
+using LibGit2Sharp;
+using LibGit2Sharp.Core;
+
+namespace LibGit2Sharp.Commands
+{
+    /// <summary>
+    /// Fetch changes from the configured upstream remote and branch into the branch pointed at by HEAD.
+    /// </summary>
+    public class Pull
+    {
+        private readonly Repository repository;
+        private readonly Signature merger;
+        private readonly PullOptions options;
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="LibGit2Sharp.Commands.Pull"/> class.
+        /// </summary>
+        /// <param name="repository">The repository.</param>
+        /// <param name="merger">The signature to use for the merge.</param>
+        /// <param name="options">The options for fetch and merging.</param>
+        public Pull(Repository repository, Signature merger, PullOptions options)
+        {
+            Ensure.ArgumentNotNull(repository, "repository");
+            Ensure.ArgumentNotNull(merger, "merger");
+            Ensure.ArgumentNotNull(options, "options");
+
+            this.repository = repository;
+            this.merger = merger;
+            this.options = options;
+        }
+
+        /// <summary>
+        /// Run this command
+        /// </summary>
+        public MergeResult Run()
+        {
+
+            Branch currentBranch = repository.Head;
+
+            if (!currentBranch.IsTracking)
+            {
+                throw new LibGit2SharpException("There is no tracking information for the current branch.");
+            }
+
+            using (var remote = repository.Network.Remotes.RemoteForName(currentBranch.RemoteName))
+            {
+                if (remote == null)
+                {
+                    throw new LibGit2SharpException("No upstream remote for the current branch.");
+                }
+
+                repository.Network.Fetch(remote, options.FetchOptions);
+                return repository.MergeFetchedRefs(merger, options.MergeOptions);
+            }
+        }
+    }
+}
+

LibGit2Sharp/LibGit2Sharp.csproj

@@ -350,6 +350,7 @@
     <Compile Include="Core\Handles\Libgit2Object.cs" />
     <Compile Include="Core\GitCredential.cs" />
     <Compile Include="Core\GitCredentialUserpass.cs" />
+    <Compile Include="Commands\Pull.cs" />
   </ItemGroup>
   <ItemGroup>
     <CodeAnalysisDictionary Include="CustomDictionary.xml" />
@@ -386,4 +387,7 @@
   <Target Name="AfterBuild">
   </Target>
   -->
+  <ItemGroup>
+    <Folder Include="Commands\" />
+  </ItemGroup>
 </Project>

LibGit2Sharp/Network.cs

@@ -549,29 +549,10 @@ public virtual void Push(Remote remote, IEnumerable<string> pushRefSpecs, PushOp
         /// </summary>
         /// <param name="merger">If the merge is a non-fast forward merge that generates a merge commit, the <see cref="Signature"/> of who made the merge.</param>
         /// <param name="options">Specifies optional parameters controlling merge behavior of pull; if null, the defaults are used.</param>
+        [Obsolete("This method is deprecated. Please use the LibGit2Sharp.Commands.Pull class")]
         public virtual MergeResult Pull(Signature merger, PullOptions options)
         {
-            Ensure.ArgumentNotNull(merger, "merger");
-            Ensure.ArgumentNotNull(options, "options");
-
-            Branch currentBranch = repository.Head;
-
-            if (!currentBranch.IsTracking)
-            {
-                throw new LibGit2SharpException("There is no tracking information for the current branch.");
-            }
-
-            string remoteName = currentBranch.RemoteName;
-            if (remoteName == null)
-            {
-                throw new LibGit2SharpException("No upstream remote for the current branch.");
-            }
-
-            using (var remote = repository.Network.Remotes.RemoteForName(remoteName))
-            {
-                Fetch(remote, options.FetchOptions);
-                return repository.MergeFetchedRefs(merger, options.MergeOptions);
-            }
+            return new Commands.Pull(repository, merger, options).Run();
         }
 
         /// <summary>