From 90a73be66a4638fcc644ab62d234c2f6b867309e Mon Sep 17 00:00:00 2001 From: Simon Eisenmann Date: Tue, 13 Oct 2026 17:06:17 +0200 Subject: [PATCH] Add Check identifier step running make -C identifier check The build job bundled the identifier web app but never ran its lint, type check or tests. Dependabot's grouped update #278 moved jsdom to 30.1.2, with which Vitest cannot start a single test file, and CI still reported success. build.yml now runs make -C identifier check, which is Biome, tsc and Vitest, after the Go lint and before the build, so a dependency update which breaks any of them turns the run red. The step needs no extra setup. The Vendor step already installs the web app dependencies, and since the test target generates the app icon it needs, check also works on a fresh checkout that was never built. It leaves no tracked file changed, so the clean check of the later Dist step is unaffected. From a clean worktree, after make -C identifier vendor, the check passes on master with 317 tests and leaves git status clean apart from the workflow. With jsdom 30.1.2 the same target fails. --- .github/workflows/build.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ba003bf7..2af1797e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -67,6 +67,11 @@ jobs: skip-cache: true only-new-issues: true + # The build only bundles the web app, so its lint, type check and tests + # run here, where a dependency update which breaks them turns the run red. + - name: Check identifier + run: make -C identifier check + - name: Build run: | make DATE=reproducible