RSA: use consistently ltc_rsa_op_checked (+ cosmetic renaming op_check >> op_checked)

Author: karel-m

src/headers/tomcrypt_private.h

@@ -469,7 +469,7 @@ typedef enum ltc_rsa_op {
    LTC_PKCS1_VERIFY  = LTC_RSA_OP_PKCS1 | LTC_RSA_VERIFY,
 } ltc_rsa_op;
 
-typedef struct ltc_rsa_op_check {
+typedef struct ltc_rsa_op_checked {
    const rsa_key *key;
    ltc_rsa_op_parameters *params;
    int hash_alg, mgf1_hash_alg;

src/pk/rsa/rsa_sign_hash.c

@@ -25,14 +25,14 @@ int rsa_sign_hash_v2(const unsigned char   *hash,   unsigned long  hashlen,
 {
    unsigned long modulus_bitlen, modulus_bytelen, x, y;
    int           err;
-   ltc_rsa_op_checked op_check = ltc_rsa_op_checked_init(key, params);
+   ltc_rsa_op_checked op_checked = ltc_rsa_op_checked_init(key, params);
 
    LTC_ARGCHK(hash     != NULL);
    LTC_ARGCHK(sig      != NULL);
    LTC_ARGCHK(siglen   != NULL);
    LTC_ARGCHK(key      != NULL);
 
-   if ((err = rsa_key_valid_op(LTC_RSA_SIGN, &op_check)) != CRYPT_OK) {
+   if ((err = rsa_key_valid_op(LTC_RSA_SIGN, &op_checked)) != CRYPT_OK) {
      return err;
    }
 
@@ -68,7 +68,7 @@ int rsa_sign_hash_v2(const unsigned char   *hash,   unsigned long  hashlen,
          hash    OCTET STRING
         }
      */
-      LTC_SET_ASN1(digestinfo, 0, LTC_ASN1_OBJECT_IDENTIFIER, hash_descriptor[op_check.hash_alg].OID, hash_descriptor[op_check.hash_alg].OIDlen);
+      LTC_SET_ASN1(digestinfo, 0, LTC_ASN1_OBJECT_IDENTIFIER, hash_descriptor[op_checked.hash_alg].OID, hash_descriptor[op_checked.hash_alg].OIDlen);
       LTC_SET_ASN1(digestinfo, 1, LTC_ASN1_NULL,              NULL,                          0);
       LTC_SET_ASN1(siginfo,    0, LTC_ASN1_SEQUENCE,          digestinfo,                    2);
       LTC_SET_ASN1(siginfo,    1, LTC_ASN1_OCTET_STRING,      hash,                            hashlen);

src/pk/rsa/rsa_verify_hash.c

@@ -29,7 +29,7 @@ int rsa_verify_hash_v2(const unsigned char   *sig,    unsigned long  siglen,
   unsigned long modulus_bitlen, modulus_bytelen, x;
   int           err;
   unsigned char *tmpbuf;
-  ltc_rsa_op_checked op_check = ltc_rsa_op_checked_init(key, params);
+  ltc_rsa_op_checked op_checked = ltc_rsa_op_checked_init(key, params);
 
   LTC_ARGCHK(hash  != NULL);
   LTC_ARGCHK(sig   != NULL);
@@ -39,7 +39,7 @@ int rsa_verify_hash_v2(const unsigned char   *sig,    unsigned long  siglen,
   /* default to invalid */
   *stat = 0;
 
-  if ((err = rsa_key_valid_op(LTC_RSA_VERIFY, &op_check)) != CRYPT_OK) {
+  if ((err = rsa_key_valid_op(LTC_RSA_VERIFY, &op_checked)) != CRYPT_OK) {
     return err;
   }
 
@@ -131,8 +131,8 @@ int rsa_verify_hash_v2(const unsigned char   *sig,    unsigned long  siglen,
 
       /* test OID */
       if ((reallen == outlen) &&
-          (digestinfo[0].size == hash_descriptor[op_check.hash_alg].OIDlen) &&
-        (XMEMCMP(digestinfo[0].data, hash_descriptor[op_check.hash_alg].OID, sizeof(unsigned long) * hash_descriptor[op_check.hash_alg].OIDlen) == 0) &&
+          (digestinfo[0].size == hash_descriptor[op_checked.hash_alg].OIDlen) &&
+        (XMEMCMP(digestinfo[0].data, hash_descriptor[op_checked.hash_alg].OID, sizeof(unsigned long) * hash_descriptor[op_checked.hash_alg].OIDlen) == 0) &&
           (siginfo[1].size == hashlen) &&
         (XMEMCMP(siginfo[1].data, hash, hashlen) == 0)) {
          *stat = 1;