Fixed exit code related integration tests (#625)

Author: ezilber-akamai

tests/integration/cli/test_host_overrides.py

@@ -2,13 +2,16 @@
 
 from pytest import MonkeyPatch
 
+from linodecli.exit_codes import ExitCodes
 from tests.integration.helpers import INVALID_HOST, exec_failing_test_command
 
 
 def test_cli_command_fails_to_access_invalid_host(monkeypatch: MonkeyPatch):
     monkeypatch.setenv("LINODE_CLI_API_HOST", INVALID_HOST)
 
-    process = exec_failing_test_command(["linode-cli", "linodes", "ls"])
+    process = exec_failing_test_command(
+        ["linode-cli", "linodes", "ls"], ExitCodes.UNRECOGNIZED_COMMAND
+    )
     output = process.stderr.decode()
 
     expected_output = ["Max retries exceeded with url:", "wrongapi.linode.com"]
@@ -29,7 +32,9 @@ def test_cli_command_fails_to_access_invalid_api_scheme(
     monkeypatch: MonkeyPatch,
 ):
     monkeypatch.setenv("LINODE_CLI_API_SCHEME", "ssh")
-    process = exec_failing_test_command(["linode-cli", "linodes", "ls"])
+    process = exec_failing_test_command(
+        ["linode-cli", "linodes", "ls"], ExitCodes.UNRECOGNIZED_COMMAND
+    )
     output = process.stderr.decode()
 
     assert "ssh://" in output

tests/integration/helpers.py

@@ -4,6 +4,8 @@
 from string import ascii_lowercase
 from typing import Callable, List
 
+from linodecli.exit_codes import ExitCodes
+
 BASE_URL = "https://api.linode.com/v4/"
 INVALID_HOST = "https://wrongapi.linode.com"
 SUCCESS_STATUS_CODE = 0
@@ -34,7 +36,9 @@ def exec_test_command(args: List[str]):
     return process
 
 
-def exec_failing_test_command(args: List[str], expected_code: int = 1):
+def exec_failing_test_command(
+    args: List[str], expected_code: int = ExitCodes.REQUEST_FAILED
+):
     process = subprocess.run(args, stderr=subprocess.PIPE)
     assert process.returncode == expected_code
     return process

tests/integration/image/test_plugin_image_upload.py

@@ -57,7 +57,7 @@ def test_invalid_file(
     )
     output = process.stdout.decode()
 
-    assert process.returncode == 2
+    assert process.returncode == 8
     assert f"No file at {file_path}" in output