From a19565b772ad73c25fab9605498af74e8f35022e Mon Sep 17 00:00:00 2001 From: zhaofangxun Date: Wed, 26 Aug 2026 15:16:25 +0800 Subject: [PATCH 1/2] fix(dde-apps): return empty list when firstNItems count <= 0 ItemsPage::firstNItems(count) appended an item before checking result.count() >= count, so firstNItems(0) (and any count <= 0) returned the first item instead of an empty list. Add an early return for count <= 0 before the loop. count > 0 behavior is unchanged (no regression). The method has no current callers, so this is an API-contract fix only. Ref: DDE-144 --- applets/dde-apps/itemspage.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/applets/dde-apps/itemspage.cpp b/applets/dde-apps/itemspage.cpp index 4c068cb16..dda2dc061 100644 --- a/applets/dde-apps/itemspage.cpp +++ b/applets/dde-apps/itemspage.cpp @@ -55,6 +55,8 @@ QStringList ItemsPage::items(int page) const QStringList ItemsPage::firstNItems(int count) { QStringList result; + if (count <= 0) + return result; for (const QStringList & pageItems : std::as_const(m_pages)) { for (const QString & item : pageItems) { From 4c2ed2a6579180817ccf3b9b2f6bade5207e5e36 Mon Sep 17 00:00:00 2001 From: zhaofangxun Date: Wed, 26 Aug 2026 15:34:48 +0800 Subject: [PATCH 2/2] chore(dde-apps): update SPDX copyright year to 2023-2026 --- applets/dde-apps/itemspage.cpp | 2 +- applets/dde-apps/itemspage.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/applets/dde-apps/itemspage.cpp b/applets/dde-apps/itemspage.cpp index dda2dc061..7a916a0a1 100644 --- a/applets/dde-apps/itemspage.cpp +++ b/applets/dde-apps/itemspage.cpp @@ -1,4 +1,4 @@ -// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd. +// SPDX-FileCopyrightText: 2023-2026 UnionTech Software Technology Co., Ltd. // // SPDX-License-Identifier: GPL-3.0-or-later diff --git a/applets/dde-apps/itemspage.h b/applets/dde-apps/itemspage.h index 26f074271..d1b8b67ee 100644 --- a/applets/dde-apps/itemspage.h +++ b/applets/dde-apps/itemspage.h @@ -1,4 +1,4 @@ -// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd. +// SPDX-FileCopyrightText: 2023-2026 UnionTech Software Technology Co., Ltd. // // SPDX-License-Identifier: GPL-3.0-or-later