Fix memory leaks and add resource cleanup in lsof_destroy

- Added sfile list cleanup in lsof_destroy() (aname, name, devnm fields)
- Added hashSfile hash buckets cleanup (HbyFdi, HbyFrd, HbyFsd, HbyNm)
- Added Lproc process array cleanup
- Added path allocation tracking in ck_file_arg() to free on error
- Added lsof_destroy() call before Exit() in main.c to ensure cleanup
- Reset counters after cleanup (HbyFdiCt, HbyFrdCt, HbyFsdCt, HbyNmCt, Hs, Nlproc, procs_cap)

These fixes address major memory leaks detected by AddressSanitizer when
running with file arguments that don't exist or when processing processes.

Author: jiegec

lib/lsof.c

@@ -767,6 +767,35 @@ void lsof_destroy(struct lsof_context *ctx) {
     CLEAN(UdpSt);
     CLEAN(Pn);
 
+    /* Free sfile list */
+    {
+        struct sfile *sfp, *sfp_next;
+        for (sfp = Sfile; sfp; sfp = sfp_next) {
+            sfp_next = sfp->next;
+            CLEAN(sfp->aname);
+            CLEAN(sfp->name);
+            CLEAN(sfp->devnm);
+            CLEAN(sfp);
+        }
+        Sfile = NULL;
+    }
+
+    /* Free hashSfile hash buckets */
+    CLEAN(HbyFdi);
+    HbyFdiCt = 0;
+    CLEAN(HbyFrd);
+    HbyFrdCt = 0;
+    CLEAN(HbyFsd);
+    HbyFsdCt = 0;
+    CLEAN(HbyNm);
+    HbyNmCt = 0;
+    Hs = 0;
+
+    /* Free process array */
+    CLEAN(Lproc);
+    Nlproc = 0;
+    ctx->procs_cap = 0;
+
     CLEAN(ctx);
 }
 

lib/misc.c

@@ -768,6 +768,7 @@ void Exit(struct lsof_context *ctx, enum ExitStatus xv) /* exit() value */
                       DCpath[DCpathX]);
 #endif /* defined(HASDCACHE) */
 
+    lsof_destroy(ctx);
     exit(xv);
 }
 

src/arg.c

@@ -121,6 +121,7 @@ int ck_file_arg(struct lsof_context *ctx, int i, /* first file argument index */
     char *ap, *fnm, *fsnm, *path;
     short err = 0;
     int fsm, ftype, j, k;
+    int path_allocated = 0;
     MALLOC_S l;
     struct mounts *mp;
     static struct mounts **mmp = (struct mounts **)NULL;
@@ -145,13 +146,15 @@ int ck_file_arg(struct lsof_context *ctx, int i, /* first file argument index */
      * Loop through arguments.
      */
     for (; i < ac; i++) {
-        if (rs && (ac == 1) && (i == 0))
+        if (rs && (ac == 1) && (i == 0)) {
             path = av[i];
-        else {
+            path_allocated = 0;
+        } else {
             if (!(path = Readlink(ctx, av[i]))) {
                 ErrStat = 1;
                 continue;
             }
+            path_allocated = 1;
         }
         /*
          * Remove terminating `/' characters from paths longer than one.
@@ -172,6 +175,7 @@ int ck_file_arg(struct lsof_context *ctx, int i, /* first file argument index */
                 (void)strncpy(ap, path, k);
                 ap[k] = '\0';
                 path = ap;
+                path_allocated = 1;
             }
         }
         /*
@@ -267,6 +271,8 @@ int ck_file_arg(struct lsof_context *ctx, int i, /* first file argument index */
                             (void)fprintf(stderr, ": %s\n", strerror(en));
                         }
                         Sfile = sfp->next;
+                        if (path_allocated)
+                            (void)free((FREE_P *)path);
                         (void)free((FREE_P *)sfp);
                         ErrStat = 1;
                         continue;
@@ -561,7 +567,6 @@ int ctrl_dcache(struct lsof_context *ctx, /* context */
 }
 #endif /* defined(HASDCACHE) */
 
-
 #if defined(HASEOPT)
 /*
  * enter_efsys() -- enter path of file system whose kernel blocks are to be
@@ -2156,9 +2161,9 @@ lkup_hostnm(char *hn,       /* host name */
 
     if (!he || !he->h_addr)
         return (he);
-        /*
-         * Copy first hostname structure address to destination structure.
-         */
+    /*
+     * Copy first hostname structure address to destination structure.
+     */
 
 #if defined(HASIPv6)
     if (n->af != he->h_addrtype)

src/main.c

@@ -1353,8 +1353,9 @@ int main(int argc, char *argv[]) {
                 else
                     slp = (struct lproc **)realloc((MALLOC_P *)slp, len);
                 if (!slp) {
-                    (void)fprintf(stderr, "%s: no space for %zu sort pointers\n",
-                                  Pn, Nlproc);
+                    (void)fprintf(stderr,
+                                  "%s: no space for %zu sort pointers\n", Pn,
+                                  Nlproc);
                     Error(ctx);
                 }
             }