Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion sql_metadata/nested_resolver.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
from sql_metadata.parser import Parser

from sqlglot import exp
from sqlglot.errors import ErrorLevel
from sqlglot.generator import Generator

from sql_metadata.utils import (
Expand Down Expand Up @@ -678,7 +679,13 @@ def _body_sql(node: exp.Expression) -> str:
body = node.copy()
for ident in body.find_all(exp.Identifier):
ident.set("quoted", False)
return _PreservingGenerator().generate(body, copy=False)
# IGNORE unsupported-feature warnings: the rendered SQL is only fed
# back into a sub-Parser and never shown to the user, so warnings
# about constructs sqlglot can't faithfully re-emit (e.g. T-SQL
# FOR XML PATH) are noise.
return _PreservingGenerator(unsupported_level=ErrorLevel.IGNORE).generate(
body, copy=False
)

@staticmethod
def _walk_subqueries(
Expand Down
16 changes: 16 additions & 0 deletions test/test_mssql_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,3 +187,19 @@ def test_mssql_catalog_double_dot():
"""SQL Server three-part name with empty db: catalog..table."""
p = Parser("SELECT * FROM mydb..orders")
assert "mydb..orders" in p.tables


def test_for_xml_path_does_not_emit_sqlglot_warning(caplog):
# Test for issue #261: T-SQL FOR XML PATH queries parsed cleanly but
# sqlglot leaked "Unsupported query option." warnings when
# NestedResolver re-rendered subquery bodies internally.
# https://github.com/macbre/sql-metadata/issues/261
query = """
SELECT B.id, STUFF((SELECT ', ' + A.[name]
FROM (SELECT id, name FROM table_enc) A
WHERE A.id = B.[id] FOR XML PATH('')), 1, 1, '') AS [output]
FROM (SELECT id FROM table_enc) B
"""
with caplog.at_level("WARNING", logger="sqlglot"):
Parser(query).columns # .columns drives NestedResolver._body_sql
assert caplog.records == []