Merge pull request #3 from maksii/copilot/sub-pr-2

Fix spurious `columns_created` in `get()` result and reduce cyclomatic complexity

Author: maksii

src/PowerPlatform/Dataverse/operations/tables.py

@@ -233,7 +233,6 @@ def get(
             "table_logical_name": raw.get("LogicalName"),
             "entity_set_name": raw.get("EntitySetName"),
             "metadata_id": raw.get("MetadataId"),
-            "columns_created": [],
         }
 
         # Include any extra selected entity properties
@@ -248,12 +247,13 @@ def get(
 
         # Include expanded relationship collections as raw dicts
         if include_relationships:
-            if "OneToManyRelationships" in raw:
-                result["one_to_many_relationships"] = raw["OneToManyRelationships"]
-            if "ManyToOneRelationships" in raw:
-                result["many_to_one_relationships"] = raw["ManyToOneRelationships"]
-            if "ManyToManyRelationships" in raw:
-                result["many_to_many_relationships"] = raw["ManyToManyRelationships"]
+            for raw_key, result_key in (
+                ("OneToManyRelationships", "one_to_many_relationships"),
+                ("ManyToOneRelationships", "many_to_one_relationships"),
+                ("ManyToManyRelationships", "many_to_many_relationships"),
+            ):
+                if raw_key in raw:
+                    result[result_key] = raw[raw_key]
 
         return result
 

tests/unit/test_tables_operations.py

@@ -130,6 +130,7 @@ def test_get_with_include_columns(self):
             include_many_to_many=False,
         )
         self.assertIn("columns", result)
+        self.assertNotIn("columns_created", result)
         self.assertEqual(len(result["columns"]), 1)
         self.assertIsInstance(result["columns"][0], ColumnMetadata)
         self.assertEqual(result["columns"][0].logical_name, "name")