Skip to content

Commit b98a222

Browse files
authored
Fix "fm_open_in_explorer" in sidebar causes an exception (#79)
* Fix "fm_open_in_explorer" in sidebar causes an exception "visible_on_platforms" should be a optional arg. Signed-off-by: Jack Cherng <jfcherng@gmail.com> * Use "visible_on_platforms" for both sidebar and command palette Signed-off-by: Jack Cherng <jfcherng@gmail.com> * Make black happy Signed-off-by: Jack Cherng <jfcherng@gmail.com>
1 parent ffde24c commit b98a222

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

Side Bar.sublime-menu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,19 +79,19 @@
7979
},
8080
{
8181
"caption": "Open in Explorer",
82-
"platform": "!OSX",
8382
"command": "fm_open_in_explorer",
8483
"mnemonic": "O",
8584
"args": {
85+
"visible_on_platforms": ["windows", "linux"],
8686
"paths": []
8787
}
8888
},
8989
{
9090
"caption": "Open in Finder",
91-
"platform": "OSX",
9291
"command": "fm_open_in_explorer",
9392
"mnemonic": "O",
9493
"args": {
94+
"visible_on_platforms": ["osx"],
9595
"paths": []
9696
}
9797
},

commands/open_in_explorer.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55

66
class FmOpenInExplorerCommand(AppCommand):
7-
def run(self, visible_on_platforms, paths=None):
7+
def run(self, visible_on_platforms=None, paths=None):
88
# visible_on_platforms is just used by is_visible
99
self.window = get_window()
1010
self.view = get_view()
@@ -21,5 +21,7 @@ def run(self, visible_on_platforms, paths=None):
2121
{"dir": os.path.dirname(path), "file": os.path.basename(path)},
2222
)
2323

24-
def is_visible(self, visible_on_platforms, paths=None):
25-
return sublime.platform() in visible_on_platforms and super().is_visible()
24+
def is_visible(self, visible_on_platforms=None, paths=None):
25+
return super().is_visible() and (
26+
visible_on_platforms is None or sublime.platform() in visible_on_platforms
27+
)

0 commit comments

Comments
 (0)