Fix command settings property

The settings attribute may be initialized upon first use to ensure
the plugin API to be ready, when calling load_settings()

Author: deathaxe

commands/create_from_selection.py

@@ -31,6 +31,14 @@ class FmCreateFileFromSelectionCommand(sublime_plugin.TextCommand):
     MATCH_JS_REQUIRE = re_comp(r"require\(\s*$")
     MATCH_RUBY_REQUIRE = re_comp(r"require_relative\s*\(?\s*$")
 
+    @property
+    def settings(cls):
+        try:
+            return cls.settings_
+        except AttributeError:
+            cls.settings_ = sublime.load_settings("FileManager.sublime-settings")
+            return cls.settings_
+
     def run(self, edit, event):
         base_path, input_path = self.get_path(event)
         abspath = computer_friendly(os.path.join(base_path, input_path))
@@ -139,7 +147,7 @@ def is_visible(self, event=None):
         if event is None:
             return False
         return (
-            self.settings.get("show_create_from_selection_command")
+            self.settings.get("show_create_from_selection_command") is True
             and self.view.file_name() is not None
             and self.get_path(event) is not None
         )

commands/fmcommand.py

@@ -5,12 +5,17 @@
 
 class FmWindowCommand(sublime_plugin.WindowCommand):
 
-    settings = sublime.load_settings("FileManager.sublime-settings")
+    @property
+    def settings(cls):
+        try:
+            return cls.settings_
+        except AttributeError:
+            cls.settings_ = sublime.load_settings("FileManager.sublime-settings")
+            return cls.settings_
 
     def is_visible(self, *args, **kwargs):
-        show = self.settings.get(
-            "show_{}_command".format(self.name().replace("fm_", ""))
-        )
+        name = "show_{}_command".format(self.name().replace("fm_", ""))
+        show = self.settings.get(name)
         if show is None:
             # this should never happen, this is an error
             # we could nag the user to get him to report that issue,