Skip to content

Commit fc3f625

Browse files
committed
Update to otel-cpp 1.24
1 parent 25af979 commit fc3f625

2 files changed

Lines changed: 15 additions & 24 deletions

File tree

CMakeLists.txt

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,6 @@ option(WITH_OTLP_FILE "Whether to include the OTLP file exporter" OFF)
9898
if(NOT WITH_OTLP_HTTP AND NOT WITH_OTLP_GRPC AND NOT WITH_OTLP_FILE)
9999
message(FATAL_ERROR "At least one of WITH_OTLP_HTTP, WITH_OTLP_GRPC, or WITH_OTLP_FILE must be ON")
100100
endif()
101-
if(APPLE)
102-
option(SKIP_OTEL_CPP_PATCH "Whether to skip patching OpenTelemetry-cpp" OFF)
103-
endif()
104101
option(WITH_EXAMPLES "Whether to build examples" OFF)
105102

106103
# set vcpkg features depending on specified options
@@ -174,6 +171,19 @@ if(WITH_OTLP_GRPC)
174171
${GRPC_INSTALL_LIB_DIR}/upb_message_lib.lib
175172
${GRPC_INSTALL_LIB_DIR}/upb_textformat_lib.lib
176173
${GRPC_INSTALL_LIB_DIR}/utf8_range_lib.lib)
174+
elseif(APPLE)
175+
set(GRPC_LINK_LIBRARIES ${GRPC_INSTALL_LIB_DIR}/libaddress_sorting.dylib
176+
${GRPC_INSTALL_LIB_DIR}/libgpr.dylib
177+
${GRPC_INSTALL_LIB_DIR}/libgrpc++.dylib
178+
${GRPC_INSTALL_LIB_DIR}/libgrpc++_unsecure.dylib
179+
${GRPC_INSTALL_LIB_DIR}/libgrpc.dylib
180+
${GRPC_INSTALL_LIB_DIR}/libgrpc_unsecure.dylib
181+
${GRPC_INSTALL_LIB_DIR}/libupb_base_lib.dylib
182+
${GRPC_INSTALL_LIB_DIR}/libupb_json_lib.dylib
183+
${GRPC_INSTALL_LIB_DIR}/libupb_mem_lib.dylib
184+
${GRPC_INSTALL_LIB_DIR}/libupb_message_lib.dylib
185+
${GRPC_INSTALL_LIB_DIR}/libupb_textformat_lib.dylib
186+
${GRPC_INSTALL_LIB_DIR}/libutf8_range_lib.dylib)
177187
else()
178188
set(GRPC_LINK_LIBRARIES ${GRPC_INSTALL_LIB_DIR}/libgrpc++${CMAKE_SHARED_LIBRARY_SUFFIX})
179189
endif()
@@ -284,17 +294,11 @@ if(NOT DEFINED OTEL_CPP_INSTALLED_DIR)
284294
set(OTEL_CPP_ABI_VERSION OPENTELEMETRY_ABI_VERSION_NO=2)
285295

286296
set(PATCHES_DIR ${CMAKE_SOURCE_DIR}/patches)
287-
if(SKIP_OTEL_CPP_PATCH)
288-
set(OTEL_CPP_PATCH_CMD "")
289-
elseif(WIN32)
297+
set(OTEL_CPP_PATCH_CMD "")
298+
if(WIN32 AND NOT SKIP_OTEL_CPP_PATCH)
290299
# Windows patch to add a preprocessor definition _DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR
291300
# See https://github.com/mathworks/OpenTelemetry-Matlab/issues/130
292301
set(OTEL_CPP_PATCH_CMD git apply ${PATCHES_DIR}/otel-cpp-windows.patch)
293-
elseif(APPLE)
294-
# Mac patch to fix a linker issue when including gRPC exporter
295-
set(OTEL_CPP_PATCH_CMD git apply ${PATCHES_DIR}/otel-cpp-mac.patch)
296-
else()
297-
set(OTEL_CPP_PATCH_CMD "")
298302
endif()
299303

300304
if(WITH_OTLP_GRPC)

patches/otel-cpp-mac.patch

Lines changed: 0 additions & 13 deletions
This file was deleted.

0 commit comments

Comments
 (0)