From 88d7da8bb45219ed12d6540fa54a39b0625c5322 Mon Sep 17 00:00:00 2001 From: "melodic-standards-sync[bot]" <300666570+melodic-standards-sync[bot]@users.noreply.github.com> Date: Sat, 31 Oct 2026 06:04:55 +0000 Subject: [PATCH] chore: sync standards components (98173214e714cf47585a3abdd5e8e221969f5f02) --- REVIEW.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/REVIEW.md b/REVIEW.md index d213590..0004102 100644 --- a/REVIEW.md +++ b/REVIEW.md @@ -20,7 +20,7 @@ section. ## Severity -This organization's criteria (`conventions/review/` in `standards`) resolve +This organization's criteria (`standards/review/` in `standards`) resolve to three severities: **Critical**, **Important**, **Suggestion**. On this surface's three markers: @@ -36,7 +36,7 @@ to the three-tier vocabulary above and not something a criterion assigns. A finding tagged `blocking` is always 🔴 Important here, regardless of what severity its underlying criterion would otherwise carry in context. -`blocking` is this file's own tag, not a severity a `conventions/review/` +`blocking` is this file's own tag, not a severity a `standards/review/` criterion assigns. ## Depth @@ -45,7 +45,7 @@ Managed Code Review cannot resolve a citation below: `@` imports are not expanded and cited files are not read into the prompt. A self-hosted or local review using the `review` plugin can follow one into the full criterion, its severity nuance, and its sources. A citation is a path of the -form `conventions/review/.md#`, resolved relative to wherever +form `standards/review/.md#`, resolved relative to wherever the `standards` checkout root is available: this repository's own root when `standards` reviews itself, or the `--add-dir` mount root everywhere else. @@ -68,14 +68,14 @@ Always check: - A high-risk security action, such as authentication, an authorization failure, a privilege change, or sensitive-data access, has a corresponding audit-log - entry (`conventions/review/observability.md#logging`). This is an + entry (`standards/review/observability.md#logging`). This is an observability completeness check on the logging seam; whether the action itself is safe is the security lane's question. - A change that writes two or more related records, files, or state locations carries an atomicity mechanism spanning them: a transaction, an atomic rename, a constraint, or a compensation step. An interruption between steps must not leave state no code path expects - (`conventions/review/error-handling.md#atomicity`). + (`standards/review/error-handling.md#atomicity`). - No Dependabot pull request waits on a human. One whose updates are all non-major, with GitHub Actions only from `actions/*`, `github/*` or `anthropics/*`, and none in the policy's `reviewOnly` security-critical @@ -99,12 +99,12 @@ Always check: - A handler or endpoint that receives an object id (a path segment, body field, or query parameter) checks the caller is authorized for that specific record, not only that the id is well-formed. Tagged `blocking` - (`conventions/review/security.md#object-level-authorization`). + (`standards/review/security.md#object-level-authorization`). - A data-access path that reaches tenant-owned data carries an explicit tenant scope. Tagged `blocking` - (`conventions/review/multi-tenancy.md#tenant-scoped-data-access`). + (`standards/review/multi-tenancy.md#tenant-scoped-data-access`). - No secret, token, or credential is added to tracked source or config. - Tagged `blocking` (`conventions/review/security.md#secrets-and-credentials`). + Tagged `blocking` (`standards/review/security.md#secrets-and-credentials`). - A query or process invocation built from external input is parameterized, never string-concatenated. Tagged `blocking` - (`conventions/review/security.md#trust-boundaries-and-injection`). + (`standards/review/security.md#trust-boundaries-and-injection`).