Skip to content

Commit 6a799ae

Browse files
committed
Using tick and cross emoji, hope this works. Also clearer language with header test
1 parent 19fa586 commit 6a799ae

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

‎tests.sh‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ RED=$(echo -en '\033[01;31m')
1717
GREEN=$(echo -en '\033[01;32m')
1818

1919
function failed {
20-
echo "${RED}✗${1}${RESTORE}"
20+
echo "${RED}❌ ${1}${RESTORE}"
2121
}
2222

2323
function passed {
24-
echo "${GREEN}✓${1}${RESTORE}"
24+
echo "${GREEN}✅ ${1}${RESTORE}"
2525
}
2626

2727
wait_for_ready() {
@@ -71,7 +71,7 @@ if [[ -n "${GITHUB_ACTIONS:-}" ]]; then
7171
fi
7272
else
7373
echo " Local run. Build image "
74-
docker build --no-cache -t mendhak/http-https-echo:testing .
74+
docker build -t mendhak/http-https-echo:testing .
7575
fi
7676

7777

@@ -249,14 +249,14 @@ message " Start container with max header size "
249249
docker run -d --rm -e MAX_HEADER_SIZE=1000 --name http-echo-tests -p 8080:8080 -p 8443:8443 -t mendhak/http-https-echo:testing
250250
wait_for_ready
251251

252-
message " Make request with a header within limit."
253-
LARGE_HEADER_VALUE=$(head -c 600 </dev/urandom | base64 | tr -d '\n')
254-
REQUEST=$(curl -s -k -H "Large-Header: $LARGE_HEADER_VALUE" https://localhost:8443/)
252+
message " Make request with a reasonable header size."
253+
REASONABLE_HEADER_VALUE=$(head -c 600 </dev/urandom | base64 | tr -d '\n')
254+
REQUEST=$(curl -s -k -H "Large-Header: $REASONABLE_HEADER_VALUE" https://localhost:8443/)
255255

256-
if [[ "$(echo "$REQUEST" | jq -r '.headers."large-header"')" == "$LARGE_HEADER_VALUE" ]]; then
257-
passed "Large header test passed."
256+
if [[ "$(echo "$REQUEST" | jq -r '.headers."large-header"')" == "$REASONABLE_HEADER_VALUE" ]]; then
257+
passed "Reasonable header test passed."
258258
else
259-
failed "Large header test failed."
259+
failed "Reasonable header test failed."
260260
echo "$REQUEST" | jq
261261
exit 1
262262
fi

0 commit comments

Comments
 (0)