Skip to content

Commit 1f7e3b5

Browse files
authored
Fixed build when PATH contains spaces (#140)
Fixes issue introduced in #63 - if PATH contains spaces (or special characters) when this line of the Makefile runs, it will corrupt the PATH variable and the build will fail. Putting quotes around the result of the string substitution fixes this.
1 parent 8d01c83 commit 1f7e3b5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

libmicroros.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ $(EXTENSIONS_DIR)/micro_ros_src/src:
8585
$(EXTENSIONS_DIR)/micro_ros_src/install: $(EXTENSIONS_DIR)/esp32_toolchain.cmake $(EXTENSIONS_DIR)/micro_ros_dev/install $(EXTENSIONS_DIR)/micro_ros_src/src
8686
cd $(UROS_DIR); \
8787
unset AMENT_PREFIX_PATH; \
88-
PATH=$(subst /opt/ros/$(ROS_DISTRO)/bin,,$(PATH)); \
88+
PATH="$(subst /opt/ros/$(ROS_DISTRO)/bin,,$(PATH))"; \
8989
. ../micro_ros_dev/install/local_setup.sh; \
9090
colcon build \
9191
--merge-install \

0 commit comments

Comments
 (0)