Skip to content

Commit 448052c

Browse files
tpellissierclaude
andcommitted
Fix Copilot review round 2: update docstring example to match parens, add assert_called_once to tests
- Update _list_tables docstring example to show parenthesized filter format - Add assert_called_once() to 5 test methods that read call_args without first verifying the mock was called exactly once Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 15a23a1 commit 448052c

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

src/PowerPlatform/Dataverse/data/_odata.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1433,7 +1433,7 @@ def _list_tables(
14331433
:param filter: Optional additional OData ``$filter`` expression that is
14341434
combined with the default ``IsPrivate eq false`` clause using
14351435
``and``. For example, ``"SchemaName eq 'Account'"`` becomes
1436-
``"IsPrivate eq false and SchemaName eq 'Account'"``.
1436+
``"IsPrivate eq false and (SchemaName eq 'Account')"``.
14371437
When ``None`` (the default), only the ``IsPrivate eq false`` filter
14381438
is applied.
14391439
:type filter: ``str`` or ``None``

tests/unit/data/test_odata_internal.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ def test_filter_none_same_as_no_filter(self):
165165
self._setup_response([])
166166
self.od._list_tables(filter=None)
167167

168+
self.od._request.assert_called_once()
168169
call_kwargs = self.od._request.call_args
169170
params = call_kwargs.kwargs.get("params") or call_kwargs[1].get("params", {})
170171
self.assertEqual(params["$filter"], "IsPrivate eq false")
@@ -194,6 +195,7 @@ def test_select_none_omits_query_param(self):
194195
self._setup_response([])
195196
self.od._list_tables(select=None)
196197

198+
self.od._request.assert_called_once()
197199
call_kwargs = self.od._request.call_args
198200
params = call_kwargs.kwargs.get("params") or call_kwargs[1].get("params", {})
199201
self.assertNotIn("$select", params)
@@ -203,6 +205,7 @@ def test_select_empty_list_omits_query_param(self):
203205
self._setup_response([])
204206
self.od._list_tables(select=[])
205207

208+
self.od._request.assert_called_once()
206209
call_kwargs = self.od._request.call_args
207210
params = call_kwargs.kwargs.get("params") or call_kwargs[1].get("params", {})
208211
self.assertNotIn("$select", params)
@@ -212,6 +215,7 @@ def test_select_preserves_case(self):
212215
self._setup_response([])
213216
self.od._list_tables(select=["EntitySetName", "LogicalName"])
214217

218+
self.od._request.assert_called_once()
215219
call_kwargs = self.od._request.call_args
216220
params = call_kwargs.kwargs.get("params") or call_kwargs[1].get("params", {})
217221
self.assertEqual(params["$select"], "EntitySetName,LogicalName")
@@ -238,6 +242,7 @@ def test_select_single_property(self):
238242
self._setup_response([])
239243
self.od._list_tables(select=["LogicalName"])
240244

245+
self.od._request.assert_called_once()
241246
call_kwargs = self.od._request.call_args
242247
params = call_kwargs.kwargs.get("params") or call_kwargs[1].get("params", {})
243248
self.assertEqual(params["$select"], "LogicalName")

0 commit comments

Comments
 (0)