Users/zhaodongwang/remove default credentail (#26)

* remove default credential

* remove unintended change

---------

Co-authored-by: Max Wang <zhaodongwang@microsoft.com>

Author: zhaodongwang-msft

README.md

@@ -24,8 +24,7 @@ A Python package allowing developers to connect to Dataverse environments for DD
 - Optional pandas integration (`PandasODataClient`) for DataFrame based create / get / query.
 
 Auth:
-- Credential is optional; if omitted, the SDK uses `DefaultAzureCredential`.
-- You can pass any `azure.core.credentials.TokenCredential` you prefer; examples use `InteractiveBrowserCredential` for local runs.
+- Accept only an `azure.core.credentials.TokenCredential` credential.
 - Token scope used by the SDK: `https://<yourorg>.crm.dynamics.com/.default` (derived from `base_url`).
 
 ## API Reference (Summary)
@@ -111,21 +110,13 @@ For upload files functionalities, run quickstart_file_upload.py instead
 
 ### DataverseClient (recommended)
 
-Tip: You can omit the credential and the SDK will use `DefaultAzureCredential` automatically:
-
-```python
-from dataverse_sdk import DataverseClient
-
-base_url = "https://yourorg.crm.dynamics.com"
-client = DataverseClient(base_url=base_url)  # uses DefaultAzureCredential by default
-```
-
 ```python
-from azure.identity import DefaultAzureCredential
+from azure.identity import InteractiveBrowserCredential
 from dataverse_sdk import DataverseClient
 
 base_url = "https://yourorg.crm.dynamics.com"
-client = DataverseClient(base_url=base_url, credential=DefaultAzureCredential())
+credential = InteractiveBrowserCredential()  # or DeviceCodeCredential(), ClientSecretCredential(...), etc.
+client = DataverseClient(base_url=base_url, credential=credential)
 
 # Create (returns list[str] of new GUIDs)
 account_id = client.create("account", {"name": "Acme, Inc.", "telephone1": "555-0100"})[0]

src/dataverse_sdk/auth.py

@@ -1,9 +1,7 @@
 from __future__ import annotations
 
 from dataclasses import dataclass
-from typing import Optional
 
-from azure.identity import DefaultAzureCredential
 from azure.core.credentials import TokenCredential
 
 
@@ -14,14 +12,14 @@ class TokenPair:
 
 
 class AuthManager:
-    """Azure Identity-based authentication helper for Dataverse.
-
-    Uses DefaultAzureCredential by default, or a provided TokenCredential.
-    """
-
-    def __init__(self, credential: Optional[TokenCredential] = None) -> None:
-        # Let callers inject any azure.identity credential; default to DAC
-        self.credential: TokenCredential = credential or DefaultAzureCredential()
+    """Azure Identity-based authentication helper for Dataverse."""
+
+    def __init__(self, credential: TokenCredential) -> None:
+        if not isinstance(credential, TokenCredential):
+            raise TypeError(
+                "credential must implement azure.core.credentials.TokenCredential."
+            )
+        self.credential: TokenCredential = credential
 
     def acquire_token(self, scope: str) -> TokenPair:
         """Acquire an access token for the given scope using Azure Identity."""

src/dataverse_sdk/client.py

@@ -25,9 +25,8 @@ class DataverseClient:
     base_url : str
         Your Dataverse environment URL, for example:
         ``"https://<org>.crm.dynamics.com"``. A trailing slash is ignored.
-    credential : azure.core.credentials.TokenCredential | None, optional
-        Any Azure Identity credential. If omitted, the SDK uses
-        ``DefaultAzureCredential`` internally.
+    credential : azure.core.credentials.TokenCredential
+        Azure Identity credential.
     config : DataverseConfig | None, optional
         Optional configuration (language code, SQL API name, HTTP timeouts/retries).
 
@@ -40,7 +39,7 @@ class DataverseClient:
     def __init__(
         self,
         base_url: str,
-        credential: Optional[TokenCredential] = None,
+        credential: TokenCredential,
         config: Optional[DataverseConfig] = None,
     ) -> None:
         self.auth = AuthManager(credential)