Address review: raise on unknown type, reuse factories, list all fields in docstrings

- from_api_response raises ValueError for unrecognized @odata.type
  (Dataverse only supports OneToMany and ManyToMany)
- from_api_response delegates to from_one_to_many/from_many_to_many
  instead of constructing cls() directly
- Docstrings on create methods now list all returned fields explicitly

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: tpellissier

src/PowerPlatform/Dataverse/models/relationship_info.py

@@ -130,36 +130,34 @@ def from_api_response(cls, response_data: Dict[str, Any]) -> RelationshipInfo:
 
         Detects one-to-many vs many-to-many from the ``@odata.type`` field
         in the response and maps PascalCase keys to snake_case attributes.
+        Dataverse only supports these two relationship types; an unrecognized
+        ``@odata.type`` raises :class:`ValueError`.
 
         :param response_data: Raw relationship metadata from the Web API.
         :type response_data: :class:`dict`
         :rtype: :class:`RelationshipInfo`
+        :raises ValueError: If the ``@odata.type`` is not a recognized
+            relationship type.
         """
         odata_type = response_data.get("@odata.type", "")
         rel_id = response_data.get("MetadataId")
         schema_name = response_data.get("SchemaName", "")
 
         if ODATA_TYPE_ONE_TO_MANY_RELATIONSHIP in odata_type:
-            return cls(
+            return cls.from_one_to_many(
                 relationship_id=rel_id,
                 relationship_schema_name=schema_name,
-                relationship_type="one_to_many",
-                referenced_entity=response_data.get("ReferencedEntity"),
-                referencing_entity=response_data.get("ReferencingEntity"),
-                lookup_schema_name=response_data.get("ReferencingEntityNavigationPropertyName"),
+                referenced_entity=response_data.get("ReferencedEntity", ""),
+                referencing_entity=response_data.get("ReferencingEntity", ""),
+                lookup_schema_name=response_data.get("ReferencingEntityNavigationPropertyName", ""),
             )
 
         if ODATA_TYPE_MANY_TO_MANY_RELATIONSHIP in odata_type:
-            return cls(
+            return cls.from_many_to_many(
                 relationship_id=rel_id,
                 relationship_schema_name=schema_name,
-                relationship_type="many_to_many",
-                entity1_logical_name=response_data.get("Entity1LogicalName"),
-                entity2_logical_name=response_data.get("Entity2LogicalName"),
+                entity1_logical_name=response_data.get("Entity1LogicalName", ""),
+                entity2_logical_name=response_data.get("Entity2LogicalName", ""),
             )
 
-        # Fallback: unknown type, populate what we can
-        return cls(
-            relationship_id=rel_id,
-            relationship_schema_name=schema_name,
-        )
+        raise ValueError(f"Unrecognized relationship @odata.type: {odata_type!r}")

src/PowerPlatform/Dataverse/operations/tables.py

@@ -283,7 +283,9 @@ def create_one_to_many_relationship(
         :type solution: :class:`str` or None
 
         :return: Relationship metadata with ``relationship_id``,
-            ``lookup_schema_name``, and entity names.
+            ``relationship_schema_name``, ``relationship_type``,
+            ``lookup_schema_name``, ``referenced_entity``, and
+            ``referencing_entity``.
         :rtype: :class:`~PowerPlatform.Dataverse.models.relationship_info.RelationshipInfo`
 
         :raises ~PowerPlatform.Dataverse.core.errors.HttpError:
@@ -358,7 +360,8 @@ def create_many_to_many_relationship(
         :type solution: :class:`str` or None
 
         :return: Relationship metadata with ``relationship_id``,
-            ``relationship_schema_name``, and entity names.
+            ``relationship_schema_name``, ``relationship_type``,
+            ``entity1_logical_name``, and ``entity2_logical_name``.
         :rtype: :class:`~PowerPlatform.Dataverse.models.relationship_info.RelationshipInfo`
 
         :raises ~PowerPlatform.Dataverse.core.errors.HttpError:

tests/unit/models/test_relationship_info.py

@@ -124,13 +124,12 @@ def test_many_to_many_detection(self):
         self.assertEqual(info.entity1_logical_name, "new_employee")
         self.assertEqual(info.entity2_logical_name, "new_project")
 
-    def test_unknown_type_fallback(self):
-        """Should handle unknown @odata.type gracefully."""
+    def test_unknown_type_raises(self):
+        """Should raise ValueError for unrecognized @odata.type."""
         raw = {"MetadataId": "guid", "SchemaName": "unknown_rel"}
-        info = RelationshipInfo.from_api_response(raw)
-        self.assertEqual(info.relationship_id, "guid")
-        self.assertEqual(info.relationship_schema_name, "unknown_rel")
-        self.assertEqual(info.relationship_type, "")
+        with self.assertRaises(ValueError) as ctx:
+            RelationshipInfo.from_api_response(raw)
+        self.assertIn("Unrecognized relationship", str(ctx.exception))
 
     def test_missing_fields(self):
         """Should handle missing optional fields without error."""
@@ -141,7 +140,7 @@ def test_missing_fields(self):
         info = RelationshipInfo.from_api_response(raw)
         self.assertEqual(info.relationship_type, "one_to_many")
         self.assertIsNone(info.relationship_id)
-        self.assertIsNone(info.referenced_entity)
+        self.assertEqual(info.referenced_entity, "")
 
 
 if __name__ == "__main__":