cleanup

Author: Max Wang

examples/quickstart.py

@@ -151,86 +151,6 @@ class Status(IntEnum):
 	if metadata_id:
 		table_info["metadata_id"] = metadata_id
 
-# 6) Column metadata helpers: column create/delete
-print("Column metadata helpers (create/delete column):")
-scratch_column = f"scratch_{int(time.time())}"
-column_payload = {scratch_column: "string"}
-try:
-	log_call(f"client.create_column('{entity_schema}', {repr(column_payload)})")
-	column_create = client.create_columns(entity_schema, column_payload)
-	if not isinstance(column_create, list) or not column_create:
-		raise RuntimeError("create_column did not return schema list")
-	created_details = column_create
-	if not all(isinstance(item, str) for item in created_details):
-		raise RuntimeError("create_column entries were not schema strings")
-	attribute_schema = created_details[0]
-	odata_client = client._get_odata()
-	exists_after_create = None
-	exists_after_delete = None
-	attr_type_before = None
-	attr_type_before_norm = None
-	if metadata_id and attribute_schema:
-		_ready_message = "Column metadata not yet available"
-		def _metadata_after_create():
-			meta = odata_client._get_attribute_metadata(
-				metadata_id,
-				attribute_schema,
-				extra_select="@odata.type,AttributeType",
-			)
-			if not meta or not meta.get("MetadataId"):
-				raise RuntimeError(_ready_message)
-			return meta
-
-		ready_meta = backoff_retry(
-			_metadata_after_create,
-			delays=(0, 1, 2, 4, 8),
-			retry_http_statuses=(),
-			retry_if=lambda exc: isinstance(exc, RuntimeError) and str(exc) == _ready_message,
-		)
-		exists_after_create = bool(ready_meta)
-		raw_type = ready_meta.get("@odata.type") or ready_meta.get("AttributeType")
-		if isinstance(raw_type, str):
-			attr_type_before = raw_type
-			lowered = raw_type.lower()
-			attr_type_before_norm = lowered.rsplit(".", 1)[-1] if "." in lowered else lowered
-	log_call(f"client.delete_column('{entity_schema}', '{scratch_column}')")
-	column_delete = client.delete_columns(entity_schema, scratch_column)
-	if not isinstance(column_delete, list) or not column_delete:
-		raise RuntimeError("delete_column did not return schema list")
-	deleted_details = column_delete
-	if not all(isinstance(item, str) for item in deleted_details):
-		raise RuntimeError("delete_column entries were not schema strings")
-	if attribute_schema not in deleted_details:
-		raise RuntimeError("delete_columns response missing expected schema name")
-	if metadata_id and attribute_schema:
-		_delete_message = "Column metadata still present after delete"
-		def _ensure_removed():
-			meta = odata_client._get_attribute_metadata(metadata_id, attribute_schema)
-			if meta:
-				raise RuntimeError(_delete_message)
-			return True
-
-		removed = backoff_retry(
-			_ensure_removed,
-			delays=(0, 1, 2, 4, 8),
-			retry_http_statuses=(),
-			retry_if=lambda exc: isinstance(exc, RuntimeError) and str(exc) == _delete_message,
-		)
-		exists_after_delete = not removed
-	print({
-		"created_column": scratch_column,
-		"create_summary": created_details,
-		"delete_summary": deleted_details,
-		"attribute_type_before_delete": attr_type_before,
-		"exists_after_create": exists_after_create,
-		"exists_after_delete": exists_after_delete,
-	})
-except MetadataError as meta_err:
-	print({"column_metadata_error": str(meta_err)})
-except Exception as exc:
-	print({"column_metadata_unexpected": str(exc)})
-sys.exit(0)
-
 # Derive attribute logical name prefix from the entity logical name (segment before first underscore)
 attr_prefix = logical.split("_", 1)[0] if "_" in logical else logical
 code_key = f"{attr_prefix}_code"

src/dataverse_sdk/odata.py

@@ -680,7 +680,6 @@ def _get_attribute_metadata(
         self,
         entity_metadata_id: str,
         schema_name: str,
-        *,
         extra_select: Optional[str] = None,
     ) -> Optional[Dict[str, Any]]:
         attr_escaped = self._escape_odata_quotes(schema_name)